Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 702883002: Whitelist intentionally racy TRACE_EVENT reads and writes. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Whitelist intentionally racy TRACE_EVENT reads and writes. Chrome's tracing framework appears to be intentionally racy on its quick-reject checks, trading some data loss for better performance when disabled. People will never notice the data loss, but TSAN does. Let's assuage TSAN with some annotations. The 'volatile' val in SK_ANNOTATE_UNPROTECTED_WRITE was making this not compile, but that volatile doesn't really make sense there: the value we're writing is not what we care about, it's the destination. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot No API changes. TBR=reed BUG=skia: Committed: https://skia.googlesource.com/skia/+/e974c6244c92d32a0e4fe5639a913e78f101a056

Patch Set 1 #

Patch Set 2 : this volatile makes no sense. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M include/core/SkDynamicAnnotations.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTraceEvent.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702883002/1
6 years, 1 month ago (2014-11-05 15:09:45 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-05 15:09:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/19)
6 years, 1 month ago (2014-11-05 15:17:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702883002/20001
6 years, 1 month ago (2014-11-05 15:25:45 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-05 15:25:45 UTC) #8
commit-bot: I haz the power
Presubmit check for 702883002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 1 month ago (2014-11-05 15:25:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702883002/20001
6 years, 1 month ago (2014-11-05 15:27:45 UTC) #12
mtklein
6 years, 1 month ago (2014-11-05 15:55:07 UTC) #15
bungeman-skia
lgtm
6 years, 1 month ago (2014-11-05 16:01:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702883002/20001
6 years, 1 month ago (2014-11-05 16:03:17 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 16:03:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as e974c6244c92d32a0e4fe5639a913e78f101a056

Powered by Google App Engine
This is Rietveld 408576698