Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 702873002: Fix multitest display name bug in test scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 if (existsCache.doesFileExist(pubspecYamlPath.toNativePath())) { 830 if (existsCache.doesFileExist(pubspecYamlPath.toNativePath())) {
831 return root.join(pubspecYamlPath); 831 return root.join(pubspecYamlPath);
832 } 832 }
833 segments.removeLast(); 833 segments.removeLast();
834 } 834 }
835 return null; 835 return null;
836 } 836 }
837 837
838 void enqueueTestCaseFromTestInformation(TestInformation info) { 838 void enqueueTestCaseFromTestInformation(TestInformation info) {
839 String testName = buildTestCaseDisplayName(suiteDir, info.originTestPath, 839 String testName = buildTestCaseDisplayName(suiteDir, info.originTestPath,
840 multitestName: info.multitestKey); 840 multitestName:
841 info.optionsFromFile['isMultitest'] ? info.multitestKey : "");
841 Set<Expectation> expectations = testExpectations.expectations(testName); 842 Set<Expectation> expectations = testExpectations.expectations(testName);
842 if (info is HtmlTestInformation) { 843 if (info is HtmlTestInformation) {
843 if (TestUtils.isBrowserRuntime(configuration['runtime'])) { 844 if (TestUtils.isBrowserRuntime(configuration['runtime'])) {
844 enqueueBrowserTest([], null, info, testName, expectations); 845 enqueueBrowserTest([], null, info, testName, expectations);
845 } 846 }
846 return; 847 return;
847 } 848 }
848 var filePath = info.filePath; 849 var filePath = info.filePath;
849 var optionsFromFile = info.optionsFromFile; 850 var optionsFromFile = info.optionsFromFile;
850 851
(...skipping 1551 matching lines...) Expand 10 before | Expand all | Expand 10 after
2402 * $pass tests are expected to pass 2403 * $pass tests are expected to pass
2403 * $failOk tests are expected to fail that we won't fix 2404 * $failOk tests are expected to fail that we won't fix
2404 * $fail tests are expected to fail that we should fix 2405 * $fail tests are expected to fail that we should fix
2405 * $crash tests are expected to crash that we should fix 2406 * $crash tests are expected to crash that we should fix
2406 * $timeout tests are allowed to timeout 2407 * $timeout tests are allowed to timeout
2407 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2408 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2408 """; 2409 """;
2409 print(report); 2410 print(report);
2410 } 2411 }
2411 } 2412 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698