Chromium Code Reviews Chromium Code Reviews
Issue 702853003:
Convert fast/multicol/float-paginate-empty-lines to reftest. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/multicol/float-paginate-empty-lines.html |
| diff --git a/LayoutTests/fast/multicol/float-paginate-empty-lines.html b/LayoutTests/fast/multicol/float-paginate-empty-lines.html |
| index adeb331094e31b4dad559a5dbb46b9c9e3d802e2..4ebb06a832e0abcd5f9cdfd99e553f800690f439 100644 |
| --- a/LayoutTests/fast/multicol/float-paginate-empty-lines.html |
| +++ b/LayoutTests/fast/multicol/float-paginate-empty-lines.html |
| @@ -1,11 +1,30 @@ |
| +<!DOCTYPE html> |
| +<style> |
| + .columns { |
| + -webkit-column-count: 2; |
| + -webkit-column-gap: 0px; |
| + column-fill: auto; |
| + height: 300px; |
| + border: 2px solid black; |
|
mstensho (USE GERRIT)
2014/11/06 14:23:47
Missing line-height here, or in .dashed.
andersr
2014/11/17 10:43:15
Done.
|
| + } |
| + .dashed { |
| + border: 10px dashed maroon; |
| + } |
| + img { |
| + float: right; |
| + width: 100px; |
| + height: 200px; |
| + background-color: #cccccc; |
| + } |
| +</style> |
| <p>This test is ensuring we don't grow the height of a block improperly when a float has no line association (e.g., when it's at the end of a |
| block). The complete dashed border should be in the first column, with none of it appearing in the second column.</p> |
| - |
| -<div style="-moz-column-width:300px; -webkit-column-width:300px; column-width:300px; column-fill:auto; height:400px"> |
| -<div style="border:10px dashed maroon"> |
| -This is some text.<br> |
| -This is some text.<br>This is some text.<br>This is some text.<br>This is some text.<br>This is some text.<br>This is some text.<br> |
| -This is some text.<br>This is some text.<br>This is some text.<br>This is some text.<br> |
| -This is some text.<br> |
| -<img style="float:right;width:100px;height:200px;background-color:#cccccc"> |
| -</div> |
| +<div class="columns"> |
| + <div class="dashed"> |
| + This is some text.<br>This is some text.<br>This is some text.<br> |
| + This is some text.<br>This is some text.<br>This is some text.<br> |
| + This is some text.<br>This is some text.<br>This is some text.<br> |
| + This is some text.<br>This is some text.<br>This is some text.<br> |
| + <img> |
| + </div> |
| +</div> |
