Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 702853003: Convert fast/multicol/float-paginate-empty-lines to reftest. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/float-paginate-empty-lines to reftest. * Set 'column-gap: 0'. * Reduced height to 300px to make it more visually obvious that the float does not fit in first column. * Removed evil twin in newmulticol. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185455

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add explicit line-height. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -237 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/float-paginate-empty-lines.html View 1 1 chunk +29 lines, -9 lines 0 comments Download
A LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html View 1 1 chunk +32 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/float-paginate-empty-lines.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/float-paginate-empty-lines-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/float-paginate-empty-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/float-paginate-empty-lines-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/float-paginate-empty-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/float-paginate-empty-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/float-paginate-empty-lines-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/float-paginate-empty-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/float-paginate-empty-lines-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
andersr
6 years, 1 month ago (2014-11-05 15:03:12 UTC) #1
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/702853003/diff/1/LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html File LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html (right): https://codereview.chromium.org/702853003/diff/1/LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html#newcode5 LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html:5: border: 2px solid black; missing line-height here, or ...
6 years, 1 month ago (2014-11-06 14:23:47 UTC) #2
andersr
https://codereview.chromium.org/702853003/diff/1/LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html File LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html (right): https://codereview.chromium.org/702853003/diff/1/LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html#newcode5 LayoutTests/fast/multicol/float-paginate-empty-lines-expected.html:5: border: 2px solid black; On 2014/11/06 14:23:47, mstensho wrote: ...
6 years, 1 month ago (2014-11-17 10:43:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702853003/20001
6 years, 1 month ago (2014-11-17 10:44:46 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-17 10:44:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702853003/40001
6 years, 1 month ago (2014-11-17 12:27:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36832)
6 years, 1 month ago (2014-11-17 14:46:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702853003/40001
6 years, 1 month ago (2014-11-17 16:30:41 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 17:09:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185455

Powered by Google App Engine
This is Rietveld 408576698