Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 702843004: Transfer serviceworker state during cross site navigations too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index 519065fac9cf4baa6d6dbb2b89930be4a11dbaea..1a181a704077c9fca7f8b5f84942b9750cfdbd42 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -189,6 +189,13 @@ void ResourceLoader::MarkAsTransferring() {
CHECK(IsResourceTypeFrame(GetRequestInfo()->GetResourceType()))
<< "Can only transfer for navigations";
is_transferring_ = true;
+
+ int child_id = GetRequestInfo()->GetChildID();
+ AppCacheInterceptor::PrepareForCrossSiteTransfer(request(), child_id);
+ ServiceWorkerRequestHandler* handler =
+ ServiceWorkerRequestHandler::GetHandler(request());
+ if (handler)
+ handler->PrepareForCrossSiteTransfer(child_id);
}
void ResourceLoader::CompleteTransfer() {
@@ -198,6 +205,18 @@ void ResourceLoader::CompleteTransfer() {
// a later read stage.
DCHECK(DEFERRED_READ == deferred_stage_ ||
DEFERRED_RESPONSE_COMPLETE == deferred_stage_);
+ DCHECK(is_transferring_);
+
+ // In some cases, a process transfer doesn't really happen and the
+ // request is resumed in the original process. Real transfers to a new process
+ // are completed via ResourceDispatcherHostImpl::UpdateRequestForTransfer.
+ int child_id = GetRequestInfo()->GetChildID();
+ AppCacheInterceptor::MaybeCompleteCrossSiteTransferInOldProcess(
+ request(), child_id);
+ ServiceWorkerRequestHandler* handler =
+ ServiceWorkerRequestHandler::GetHandler(request());
+ if (handler)
+ handler->MaybeCompleteCrossSiteTransferInOldProcess(child_id);
is_transferring_ = false;
GetRequestInfo()->cross_site_handler()->ResumeResponse();

Powered by Google App Engine
This is Rietveld 408576698