Make merge_to_branch more git-friendly.

Make merge_to_branch more git-friendly.

BUG=410721
LOG=n
TEST=script_test.py
R=tandrii@chromium.org
TBR=tandrii@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=25154

[Michael Achenbach, 2014-11-05 11:05:07]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2014-11-05 11:06:55]

PTAL

[tandrii(chromium), 2014-11-05 12:59:16]

LGTM % comments

https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to...
File tools/push-to-trunk/merge_to_branch.py (right):

https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to...
tools/push-to-trunk/merge_to_branch.py:120: self["full_revision_list"]))
I think this is shorter and more readable:
join(action_text % s for s in self["full_revision_list"])

Also, I don't like += to grow strings, though here it's arguably justified.
Still, consider building self["new_commit_msg"] using a list of strings, joined
at the end.

https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to...
tools/push-to-trunk/merge_to_branch.py:132: bugs.extend(map(lambda s: s.strip(),
bug.split(",")))
consider shorter:
bugs.extend(s.strip() for s in bug.split(","))

[Michael Achenbach, 2014-11-05 13:30:37]

https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to...
File tools/push-to-trunk/merge_to_branch.py (right):

https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to...
tools/push-to-trunk/merge_to_branch.py:120: self["full_revision_list"]))
On 2014/11/05 12:59:15, tandrii wrote:
> I think this is shorter and more readable:
> join(action_text % s for s in self["full_revision_list"])
> 
> Also, I don't like += to grow strings, though here it's arguably justified.
> Still, consider building self["new_commit_msg"] using a list of strings,
joined
> at the end.

Done.

https://codereview.chromium.org/702843002/diff/1/tools/push-to-trunk/merge_to...
tools/push-to-trunk/merge_to_branch.py:132: bugs.extend(map(lambda s: s.strip(),
bug.split(",")))
On 2014/11/05 12:59:15, tandrii wrote:
> consider shorter:
> bugs.extend(s.strip() for s in bug.split(","))

Done.

[Michael Achenbach, 2014-11-05 13:31:00]

Committed patchset #2 (id:20001) manually as 25154 (presubmit successful).