Fixed command-line to app shim in Windows app file association.

Fixed command-line to app shim in Windows app file association.

Previously was missing switches to the shim.

BUG=430361
Committed: https://crrev.com/250e8dcb88d80038e8780df8c506d14314f98ade
Cr-Commit-Position: refs/heads/master@{#302765}

[Matt Giuca, 2014-11-05 06:45:11]

mgiuca@chromium.org changed reviewers:
+ jackhou@chromium.org

[Matt Giuca, 2014-11-05 06:45:12]

Whoops, I messed up and the previous CL doesn't actually create valid
associations. (Introduced this bug in the last few patch sets of the previous
CL.)

https://codereview.chromium.org/702803002/diff/1/chrome/browser/web_applicati...
File chrome/browser/web_applications/web_app_win.cc (right):

https://codereview.chromium.org/702803002/diff/1/chrome/browser/web_applicati...
chrome/browser/web_applications/web_app_win.cc:430: for (size_t i = 1; i <
chrome_cmd_line.argv().size(); ++i)
Note: The old code was calling GetArgs(), which returns args but not switches.

The new code gets all the args, but starts from 0 (so it omits the program).

[jackhou1, 2014-11-05 07:23:30]

lgtm

But it sounds like we need some tests.

[Matt Giuca, 2014-11-05 07:24:38]

yeah... so there are no tests at all for web_app_win (and there is always
inertia when there are no tests to add a new test file to test a handful of
functions). But I think I will add a test for at least GetAppShimCommandLine and
maybe some others that don't cause widespread system changes.

[Matt Giuca, 2014-11-05 07:24:41]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-11-05 07:25:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702803002/1

[commit-bot: I haz the power, 2014-11-05 08:11:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-05 08:12:28]

Patchset 1 (id:??) landed as
https://crrev.com/250e8dcb88d80038e8780df8c506d14314f98ade
Cr-Commit-Position: refs/heads/master@{#302765}