Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 702723003: Address some build warnings. (Closed)

Created:
6 years, 1 month ago by newt (away)
Modified:
6 years, 1 month ago
Reviewers:
Ted C, Ignacio Solla
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Address some build warnings. 1. This suppresses a deprecation warning in ContentViewCore. We need to use AbsoluteLayout because WebView extends it, but AbsoluteLayout is deprecated. 2. This suppresses a false-positive Android lint warning. Lint complained that we should use Gravity.START instead of Gravity.LEFT in PopupTouchHandleDrawable.java, but in fact we're not using Gravity.LEFT at all; just a local constant named LEFT. Committed: https://crrev.com/819551bb1c1675c0b24a52737cd58fe17e4527b4 Cr-Commit-Position: refs/heads/master@{#302858}

Patch Set 1 #

Total comments: 1

Patch Set 2 : don't remove AbsoluteLayout support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
newt (away)
PTAL
6 years, 1 month ago (2014-11-04 20:52:48 UTC) #2
Ignacio Solla
https://codereview.chromium.org/702723003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (left): https://codereview.chromium.org/702723003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#oldcode232 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:232: } else if (mCurrentContainerView instanceof android.widget.AbsoluteLayout) { Do not ...
6 years, 1 month ago (2014-11-05 10:17:08 UTC) #3
newt (away)
tedchoc: PTAL
6 years, 1 month ago (2014-11-05 18:27:13 UTC) #5
newt (away)
On 2014/11/05 10:17:08, Ignacio Solla wrote: > https://codereview.chromium.org/702723003/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java > File > content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java > (left): > ...
6 years, 1 month ago (2014-11-05 18:27:54 UTC) #6
Ted C
lgtm
6 years, 1 month ago (2014-11-05 18:30:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702723003/20001
6 years, 1 month ago (2014-11-05 18:35:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 20:16:54 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 20:17:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/819551bb1c1675c0b24a52737cd58fe17e4527b4
Cr-Commit-Position: refs/heads/master@{#302858}

Powered by Google App Engine
This is Rietveld 408576698