Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 702703002: Revert of Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. (Closed)

Created:
6 years, 1 month ago by Bernhard Bauer
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. (patchset #2 id:20001 of https://codereview.chromium.org/700503002/) Reason for revert: content_browsertests are failing on the main waterfall (http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23894/steps/content_browsertests/logs/stdio) as well as trybots. Original issue's description: > Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. > > YCWebCameraSource.ax causes a huge amount of Chrome crashes. This CL > changes the initialization model of the Device Thread, a.k.a Audio > Thread, from Multiple Thread appartment model to Single Thread model, > MTA -> STA. > > We'll monitor the crash rate in the Canaries to see if it has the > desired effect. > > BUG=427192, 421991 > > Adding this since the android_dbg_tests_recipe bot seems stalled. > NOTRY=true > > Committed: https://crrev.com/90ec5d341eb859647217c371dbe2508f1c838827 > Cr-Commit-Position: refs/heads/master@{#302596} TBR=tommi@chromium.org,mcasas@chromium.org NOTREECHECKS=true NOTRY=true BUG=427192, 421991 Committed: https://crrev.com/b312062c4f516a5d2a98fbb714478109e670d9fe Cr-Commit-Position: refs/heads/master@{#302606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Bernhard Bauer
Created Revert of Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager.
6 years, 1 month ago (2014-11-04 14:32:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702703002/1
6 years, 1 month ago (2014-11-04 14:37:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 14:38:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b312062c4f516a5d2a98fbb714478109e670d9fe Cr-Commit-Position: refs/heads/master@{#302606}
6 years, 1 month ago (2014-11-04 14:39:13 UTC) #5
Bernhard Bauer
FTR, the symbolized stack trace (from http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23894/steps/Run%20stack%20tool%20with%20logcat%20dump/logs/stdio): [FATAL:ref_counted.h(312)] Assert failed: ptr_ != __null. Stack Trace: ...
6 years, 1 month ago (2014-11-04 14:49:48 UTC) #6
Bernhard Bauer
6 years, 1 month ago (2014-11-04 14:52:24 UTC) #7
Message was sent while issue was closed.
That did not turn out nicely... Without the line numbers:

  006d756f  logging::LogMessage::~LogMessage()+42
  003e790d  scoped_refptr<base::SingleThreadTaskRunner>::operator->() const+60
  01e02015  content::VideoCaptureManager::IsOnDeviceThread() const+6
  01e02423 
content::VideoCaptureManager::DoStopDeviceOnDeviceThread(content::VideoCaptureManager::DeviceEntry*)+30
  v------>  base::Callback<void ()>::Run() const
  006be159  base::debug::TaskAnnotator::RunTask(char const*, char const*,
base::PendingTask const&)+428
  006dd3fd  base::MessageLoop::RunTask(base::PendingTask const&)+192
  006dd487  base::MessageLoop::DeferOrRunPendingTask(base::PendingTask
const&)+34
  006de7f9  base::MessageLoop::DoWork()+112
  006dee35  base::MessagePumpDefault::Run(base::MessagePump::Delegate*)+88
  006de19f  base::MessageLoop::RunHandler()+82
  006edaa7  base::RunLoop::Run()+30
  006dccef  base::MessageLoop::Run()+14
  006fede9  base::Thread::ThreadMain()+348
  006fb63d  base::(anonymous namespace)::ThreadFunc(void*)+108
  0000d173  <unknown>
  0000d30b  <unknown>

Powered by Google App Engine
This is Rietveld 408576698