Avoid redundant work in scheduler loop header/depth calculation.

Avoid redundant work in scheduler loop header/depth calculation.

R=jarin@chromium.org

TEST=cctest/test-scheduler/LoopedFloatingDiamond2

Committed: https://code.google.com/p/v8/source/detail?r=25181

[Jarin, 2014-11-05 01:03:56]

lgtm with a nit.

https://codereview.chromium.org/702683002/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/702683002/diff/1/src/compiler/scheduler.cc#ne...
src/compiler/scheduler.cc:829: current->set_rpo_number(-1);
Could we use the constant defined above? (kBlockUnvisited1)

[Michael Starzinger, 2014-11-05 10:18:40]

Thanks for the review. Addressed comments. Landing.

https://codereview.chromium.org/702683002/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/702683002/diff/1/src/compiler/scheduler.cc#ne...
src/compiler/scheduler.cc:829: current->set_rpo_number(-1);
On 2014/11/05 01:03:56, jarin wrote:
> Could we use the constant defined above? (kBlockUnvisited1)

Done.

[Michael Starzinger, 2014-11-05 16:36:00]

PTAL. Discovered a bug in my optimization with our new tests. So I fixed it,
added a cctest and extended verification.

[Jarin, 2014-11-06 09:08:49]

Looks good to me.

[Michael Starzinger, 2014-11-06 09:15:26]

Committed patchset #5 (id:80001) manually as 25181 (presubmit successful).