Issue 702663002: [CSS Grid Layout] Increase coverage for first-line pseudo-element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 702663002: [CSS Grid Layout] Increase coverage for first-line pseudo-element (Closed)

Created:
6 years, 1 month ago by Manuel Rego

Modified:
6 years, 1 month ago

Reviewers:
cbiesinger, esprehn, Julien - ping for review

CC:
blink-reviews, jfernandez, Manuel Rego, svillar

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

[CSS Grid Layout] Increase coverage for first-line pseudo-element Add missing cases checking that first-line pseudo-element from ancestors is ignored inside the grid. TEST=fast/css-grid-layout/grid-container-ignore-first-line.html BUG=395788 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184885

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
	M	LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html	View		2 chunks	+27 lines, -1 line	0 comments	Download
	M	LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Manuel Rego

Very simple patch just adding some missing cases in the current test.

6 years, 1 month ago (2014-11-04 11:59:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702663002/1

6 years, 1 month ago (2014-11-05 21:48:06 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-05 23:36:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184885

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages