Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 702603005: Add a sketch of a test_perf script (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add a sketch of a test_perf script This script isn't quite working, but it's valuable to checkpoint the work at this point. I'm coordinating with the chromeperf.appspot.com folks to get the server to accept the data. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3cfbe90e6bda2b161865818598c10fab26364a82

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -204 lines) Patch
D sky/benchmarks/layout/simple-blocks.html View 1 chunk +0 lines, -44 lines 0 comments Download
A + sky/benchmarks/layout/simple-blocks.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/benchmarks/resources/runner.sky View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/tools/sky_server View 2 chunks +4 lines, -12 lines 0 comments Download
M sky/tools/skydb View 5 chunks +8 lines, -13 lines 0 comments Download
A + sky/tools/skypy/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tools/skypy/paths.py View 1 chunk +14 lines, -0 lines 0 comments Download
M sky/tools/test_perf View 1 chunk +106 lines, -39 lines 2 comments Download
M sky/tools/tester/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tools/tester/test_harness.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/tools/tester/test_harness.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M sky/tools/tester/tester.cc View 4 chunks +47 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-05 00:07:42 UTC) #1
eseidel
lgtm https://codereview.chromium.org/702603005/diff/1/sky/tools/test_perf File sky/tools/test_perf (right): https://codereview.chromium.org/702603005/diff/1/sky/tools/test_perf#newcode45 sky/tools/test_perf:45: match = re.search(r'values (.+) ms', output, flags=re.MULTILINE) maybe ...
6 years, 1 month ago (2014-11-05 00:40:44 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-11-05 00:45:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3cfbe90e6bda2b161865818598c10fab26364a82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698