Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 702593002: bluetooth: Initial simple mock content::WebBluetoothImpl. (Closed)

Created:
6 years, 1 month ago by scheib
Modified:
6 years, 1 month ago
Reviewers:
no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, Jeffrey Yasskin
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

bluetooth: Initial simple mock content::WebBluetoothImpl. In three patches the initial mock implementation of bluetooth.requestDevice is implemented across blink & content. This allows layout tests to specify the data responses the mock implemented in content should return via testRunner.SetBluetoothMockDataSet and call bluetooth.requestDevice with the expected results. crrev.com/650613005 blink::WebBluetooth & WebBluetoothError interfaces. crrev.com/702593002 content::WebBluetoothImpl & testRunner.SetBluetoothMockDataSet. crrev.com/686813003 blink::BluetoothDiscovery::requestDevice implemented. BUG=420284 Committed: https://crrev.com/834f2690d9f30566683e9ac7758357d6fee24856 Cr-Commit-Position: refs/heads/master@{#302910}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : CONTENT_CHILD_BLUETOOTH_WEB_BLUETOOTH_IMPL_H_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -1 line) Patch
A content/child/bluetooth/web_bluetooth_impl.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A content/child/bluetooth/web_bluetooth_impl.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/layouttest_support.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 4 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +9 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 5 chunks +13 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scheib
6 years, 1 month ago (2014-11-04 22:09:06 UTC) #2
no sievers
lgtm https://codereview.chromium.org/702593002/diff/20001/content/child/bluetooth/web_bluetooth_impl.h File content/child/bluetooth/web_bluetooth_impl.h (right): https://codereview.chromium.org/702593002/diff/20001/content/child/bluetooth/web_bluetooth_impl.h#newcode5 content/child/bluetooth/web_bluetooth_impl.h:5: #ifndef CONTENT_CHILD_WEB_BLUETOOTH_IMPL_H_ CONTENT_CHILD_BLUETOOTH_WEB_BLUETOOTH_IMPL_H_
6 years, 1 month ago (2014-11-05 21:38:22 UTC) #4
scheib
Thanks. https://codereview.chromium.org/702593002/diff/20001/content/child/bluetooth/web_bluetooth_impl.h File content/child/bluetooth/web_bluetooth_impl.h (right): https://codereview.chromium.org/702593002/diff/20001/content/child/bluetooth/web_bluetooth_impl.h#newcode5 content/child/bluetooth/web_bluetooth_impl.h:5: #ifndef CONTENT_CHILD_WEB_BLUETOOTH_IMPL_H_ On 2014/11/05 21:38:22, sievers wrote: > ...
6 years, 1 month ago (2014-11-05 21:52:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702593002/40001
6 years, 1 month ago (2014-11-05 21:54:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-05 23:57:37 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 23:58:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/834f2690d9f30566683e9ac7758357d6fee24856
Cr-Commit-Position: refs/heads/master@{#302910}

Powered by Google App Engine
This is Rietveld 408576698