Source/modules/mediasource/TrackDefaultList.idl - Issue 702583002: MSE: Implement TrackDefaultList object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/mediasource/TrackDefaultList.idl

Issue 702583002: MSE: Implement TrackDefaultList object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@WIP_blink_trackdefaults_and_add_tracks_to_init_segment_processing

Patch Set: Add ::create() overload to simplify empty list creation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Per 18 Nov 2014 Editor's Draft

	6 // https://w3c.github.io/media-source/#trackdefaultlist

	7

	8 [

	9 Constructor(sequence<TrackDefault> trackDefaults),

	10 RaisesException=Constructor,

	11 GarbageCollected,

	12 RuntimeEnabled=MediaSourceExperimental,

	13 ] interface TrackDefaultList {

	14 readonly attribute unsigned long length;

	15 [ImplementedAs=item] getter TrackDefault (unsigned long index);
	haraken 2014/12/16 01:19:37 Do we need [ImplementedAs=item]? I guess a getter Do we need [ImplementedAs=item]? I guess a getter that takes 'unsigned' parameter should be recognized as an indexed getter (and thus is redirected to item()) by default. wolenetz 2014/12/16 19:29:44 Yes, we need that annotation. Otherwise, the gette Show quoted text On 2014/12/16 01:19:37, haraken wrote: > > Do we need [ImplementedAs=item]? I guess a getter that takes 'unsigned' > parameter should be recognized as an indexed getter (and thus is redirected to > item()) by default. Yes, we need that annotation. Otherwise, the getter would need to be named "anonymousIndexedGetter" in the implementation. I prefer explicit indication in idl for readability. Note, with that annotation removed, build fails: In file included from gen/blink/bindings/modules/v8/V8GeneratedModulesBindings11.cpp:32: gen/blink/bindings/modules/v8/V8TrackDefaultList.cpp:73:41: error: no member named 'anonymousIndexedGetter' in 'blink::TrackDefaultList' RawPtr<TrackDefault> result = impl->anonymousIndexedGetter(index); ~~~~ ^
	16 };

OLD	NEW

« no previous file with comments | « Source/modules/mediasource/TrackDefaultList.cpp ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »