Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 702543005: Instrumenting copying string returned by GetRawDataResource to locate the source of jankiness. (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumenting copying string returned by GetRawDataResource to locate the source of jankiness. Previous instrumentations showed that the jank is in this line: *data = rb.GetRawDataResource(resource_id_).as_string(); And its average run time is 15.1 ms. I also know that the expensive operation is outside of ResourceBundle::GetRawDataResourceForScale. So, we have to suggest that it's indeed copying the string that is responsible for the jank. BUG=422489 Committed: https://crrev.com/cc81e8300d4e586ceddab90242a31bdf0c8a2522 Cr-Commit-Position: refs/heads/master@{#302686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/extensions/chrome_url_request_util.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
vadimt
kalman@, please provide OWNERs approval
6 years, 1 month ago (2014-11-04 02:57:16 UTC) #1
vadimt
kalman@ please provide OWNER's approval
6 years, 1 month ago (2014-11-04 02:58:22 UTC) #3
not at google - send to devlin
6 years, 1 month ago (2014-11-04 17:52:43 UTC) #4
not at google - send to devlin
lgtm
6 years, 1 month ago (2014-11-04 17:52:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702543005/1
6 years, 1 month ago (2014-11-04 19:06:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8438)
6 years, 1 month ago (2014-11-04 20:22:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702543005/1
6 years, 1 month ago (2014-11-04 20:37:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 22:30:12 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:31:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc81e8300d4e586ceddab90242a31bdf0c8a2522
Cr-Commit-Position: refs/heads/master@{#302686}

Powered by Google App Engine
This is Rietveld 408576698