Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: extensions/DEPS

Issue 702513002: Refine //extensions DEPS on //ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: native_app_window +ui/aura Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/components/native_app_window/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/DEPS
diff --git a/extensions/DEPS b/extensions/DEPS
index d2bbec8b4697b7e0649188db6c6eb6d960f140a1..21a0ba611c5d533047bc5b923395944c0e57b349 100644
--- a/extensions/DEPS
+++ b/extensions/DEPS
@@ -13,7 +13,16 @@ include_rules = [
"+grit/extensions_resources.h",
"+mojo/public",
"+testing",
- "+ui",
+
+ # Minimal UI dependencies. There are two good rules for UI dependencies here:
+ #
+ # 1) UI components should only be added as they are needed, and
+ # 2) if //content doesn't allow it, //extensions probably won't allow it.
+ # (see for example ui/views)
+ "-ui",
+ "+ui/base",
+ "+ui/gfx",
+ "+ui/events",
# NOTE: Please do not add includes without talking to the app shell team;
# see OWNERS for this directory.
« no previous file with comments | « no previous file | extensions/components/native_app_window/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698