chrome/browser/profiles/profile_metrics.h - Issue 702483002: On Views, track all opens of the menu from icon AND bubble. Matches Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_metrics.h

Issue 702483002: On Views, track all opens of the menu from icon AND bubble. Matches Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/profiles/profile_metrics.h

diff --git a/chrome/browser/profiles/profile_metrics.h b/chrome/browser/profiles/profile_metrics.h

index 06b6bd3b372fc2a6466b773bc1e6fce6a7fbf957..8e4bb99dc2e18668a710fb386af5e25cc53d69fb 100644

--- a/chrome/browser/profiles/profile_metrics.h

+++ b/chrome/browser/profiles/profile_metrics.h

@@ -50,7 +50,7 @@ class ProfileMetrics {

// Enum for counting the ways user profiles and menus were opened.

enum ProfileOpen {

NTP_AVATAR_BUBBLE = 0, // User opens avatar icon menu from NTP

- ICON_AVATAR_BUBBLE, // User opens avatar icon menu from icon

+ ICON_AVATAR_BUBBLE, // User opens avatar icon menu from icon or button

noms (inactive) 2014/11/03 15:18:52 nit: i would call this the "avatar menu" not the "

Mike Lerman 2014/11/03 15:32:07 Done.

SWITCH_PROFILE_ICON, // User switches profiles from icon menu

SWITCH_PROFILE_MENU, // User switches profiles from menu bar

SWITCH_PROFILE_DOCK, // User switches profiles from dock (Mac-only)

« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')