Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 702473005: athena: Remove ActivityViewModel::CreateWidget(). (Closed)

Created:
6 years, 1 month ago by sadrul
Modified:
6 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

athena: Remove ActivityViewModel::CreateWidget(). Use the existing views API (views::Widget::GetWidgetForNativeView()) to get any existing views::Widget for an athena::Activity, instead of asking its ActivityViewModel. BUG=none R=oshima@chromium.org Committed: https://crrev.com/03222bda6cf957c899b7b312d53d7af80a6bc167 Cr-Commit-Position: refs/heads/master@{#302523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -45 lines) Patch
M athena/activity/activity_manager_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M athena/activity/public/activity_view_model.h View 1 chunk +0 lines, -4 lines 0 comments Download
M athena/content/app_activity.h View 1 chunk +0 lines, -1 line 0 comments Download
M athena/content/app_activity.cc View 4 chunks +17 lines, -18 lines 0 comments Download
M athena/content/app_activity_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M athena/content/app_activity_proxy.cc View 2 chunks +1 line, -5 lines 0 comments Download
M athena/content/app_activity_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M athena/content/web_activity.h View 1 chunk +0 lines, -1 line 0 comments Download
M athena/content/web_activity.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M athena/test/base/sample_activity.h View 1 chunk +0 lines, -1 line 0 comments Download
M athena/test/base/sample_activity.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sadrul
6 years, 1 month ago (2014-11-03 23:10:24 UTC) #2
oshima
lgtm
6 years, 1 month ago (2014-11-03 23:44:08 UTC) #3
sadrul
Committed patchset #1 (id:1) manually as 03222bda6cf957c899b7b312d53d7af80a6bc167 (presubmit successful).
6 years, 1 month ago (2014-11-03 23:57:29 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:57:32 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03222bda6cf957c899b7b312d53d7af80a6bc167
Cr-Commit-Position: refs/heads/master@{#302523}

Powered by Google App Engine
This is Rietveld 408576698