Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 702463002: [turbofan] Introduce separate SelectLowering reducer. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce separate SelectLowering reducer. Split lowering of Select nodes into a separate graph reducer and be more clever when lowering to diamonds, i.e. reuse diamonds that have the same condition and only add more phis to it. TEST=unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25078

Patch Set 1 #

Patch Set 2 : Fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -20 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +5 lines, -2 lines 0 comments Download
A src/compiler/select-lowering.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A src/compiler/select-lowering.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download
A test/unittests/compiler/select-lowering-unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-03 14:57:08 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-11-03 15:10:18 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-03 15:17:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698