Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index 356fac39cdce57219c0436abe068f1f818532c91..3d588b0177c20365f6876ca953faefcf54c4718e 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -11,7 +11,7 @@
#include "content/public/renderer/v8_value_converter.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_messages.h"
-#include "extensions/renderer/guest_view/guest_view_container.h"
+#include "extensions/renderer/guest_view/web_view_container.h"
#include "extensions/renderer/script_context.h"
#include "v8/include/v8.h"
@@ -41,15 +41,15 @@ void GuestViewInternalCustomBindings::AttachGuest(
CHECK(args.Length() < 4 || args[3]->IsFunction());
int element_instance_id = args[0]->Int32Value();
- // An element instance ID uniquely identifies a GuestViewContainer within
- // a RenderView.
- GuestViewContainer* guest_view_container =
- GuestViewContainer::FromID(context()->GetRenderView()->GetRoutingID(),
- element_instance_id);
+ // An element instance ID uniquely identifies a WebViewContainer within a
+ // RenderView.
+ WebViewContainer* web_view_container =
+ WebViewContainer::FromID(context()->GetRenderView()->GetRoutingID(),
+ element_instance_id);
// TODO(fsamuel): Should we be reporting an error if the element instance ID
// is invalid?
- if (!guest_view_container)
+ if (!web_view_container)
return;
int guest_instance_id = args[1]->Int32Value();
@@ -64,15 +64,15 @@ void GuestViewInternalCustomBindings::AttachGuest(
static_cast<base::DictionaryValue*>(params_as_value.release()));
}
- linked_ptr<GuestViewContainer::AttachRequest> request(
- new GuestViewContainer::AttachRequest(
+ linked_ptr<WebViewContainer::AttachRequest> request(
+ new WebViewContainer::AttachRequest(
element_instance_id,
guest_instance_id,
params.Pass(),
args.Length() == 4 ? args[3].As<v8::Function>() :
v8::Handle<v8::Function>(),
args.GetIsolate()));
- guest_view_container->AttachGuest(request);
+ web_view_container->AttachGuest(request);
args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
}

Powered by Google App Engine
This is Rietveld 408576698