Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: extensions/renderer/guest_view/mime_handler_view_container.cc

Issue 702433002: Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "extensions/renderer/guest_view/mime_handler_view_container.h"
6
7 #include "content/public/renderer/render_frame.h"
8 #include "extensions/common/extension_messages.h"
9 #include "extensions/common/guest_view/guest_view_constants.h"
10
11 namespace extensions {
12
13 MimeHandlerViewContainer::MimeHandlerViewContainer(
14 content::RenderFrame* render_frame,
15 const std::string& mime_type)
16 : GuestViewContainer(render_frame),
17 mime_type_(mime_type) {
18 DCHECK(!mime_type_.empty());
19 }
20
21 MimeHandlerViewContainer::~MimeHandlerViewContainer() {}
22
23 void MimeHandlerViewContainer::DidFinishLoading() {
24 DCHECK_NE(element_instance_id_, guestview::kInstanceIDNone);
25 render_frame()->Send(new ExtensionHostMsg_CreateMimeHandlerViewGuest(
26 routing_id(), html_string_, mime_type_, element_instance_id_));
27 }
28
29 void MimeHandlerViewContainer::DidReceiveData(const char* data,
30 int data_length) {
31 std::string value(data, data_length);
32 html_string_ += value;
33 }
34
35 void MimeHandlerViewContainer::Ready() {}
Fady Samuel 2014/11/04 11:47:50 If you're not using this you can get rid of it.
raymes 2014/11/04 22:56:09 I'm about to use it in a followup CL, but I've rem
36
37 bool MimeHandlerViewContainer::HandlesMessage(const IPC::Message& message) {
38 return message.type() == ExtensionMsg_CreateMimeHandlerViewGuestACK::ID ||
39 message.type() == ExtensionMsg_GuestAttached::ID;
40 }
41
42 bool MimeHandlerViewContainer::OnMessage(const IPC::Message& message) {
43 bool handled = true;
44 IPC_BEGIN_MESSAGE_MAP(MimeHandlerViewContainer, message)
45 IPC_MESSAGE_HANDLER(ExtensionMsg_CreateMimeHandlerViewGuestACK,
46 OnCreateMimeHandlerViewGuestACK)
47 IPC_MESSAGE_HANDLER(ExtensionMsg_GuestAttached, OnGuestAttached)
48 IPC_MESSAGE_UNHANDLED(handled = false)
49 IPC_END_MESSAGE_MAP()
50 return handled;
51 }
52
53 void MimeHandlerViewContainer::OnCreateMimeHandlerViewGuestACK(
54 int element_instance_id) {
55 DCHECK_NE(element_instance_id_, guestview::kInstanceIDNone);
56 DCHECK_EQ(element_instance_id_, element_instance_id);
57 render_frame()->AttachGuest(element_instance_id);
58 }
59
60 void MimeHandlerViewContainer::OnGuestAttached(int guest_proxy_routing_id) {
61 }
Fady Samuel 2014/11/04 11:47:50 If you're not using this, you can get rid of it.
raymes 2014/11/04 22:56:09 Done.
62
63 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698