Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: src/gpu/GrGeometryBuffer.h

Issue 702413003: Make GrGpuResource::gpuMemorySize non-virtual w/ onGpuMemorySize virtual impl (Closed) Base URL: https://skia.googlesource.com/skia.git@priv
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/gpu/GrTexture.h ('k') | src/gpu/GrGpuResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrGeometryBuffer.h
diff --git a/src/gpu/GrGeometryBuffer.h b/src/gpu/GrGeometryBuffer.h
index c3e1c65252c4f7376a7abd016704308173abdf38..d6761831b1cdc9464fa46953cd97ce6da8050206 100644
--- a/src/gpu/GrGeometryBuffer.h
+++ b/src/gpu/GrGeometryBuffer.h
@@ -98,9 +98,6 @@ public:
return this->onUpdateData(src, srcSizeInBytes);
}
- // GrGpuResource overrides
- virtual size_t gpuMemorySize() const { return fGpuMemorySize; }
-
protected:
GrGeometryBuffer(GrGpu* gpu, bool isWrapped, size_t gpuMemorySize, bool dynamic, bool cpuBacked)
: INHERITED(gpu, isWrapped)
@@ -110,6 +107,8 @@ protected:
, fCPUBacked(cpuBacked) {}
private:
+ virtual size_t onGpuMemorySize() const { return fGpuMemorySize; }
+
virtual void* onMap() = 0;
virtual void onUnmap() = 0;
virtual bool onUpdateData(const void* src, size_t srcSizeInBytes) = 0;
« no previous file with comments | « include/gpu/GrTexture.h ('k') | src/gpu/GrGpuResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698