Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 7024047: [Arguments] Port fast arguments creation stubs to X64 and ARM. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/arguments
Patch Set: Better ARM code. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index e1ca2d1b309d5b4be58bfc8cb98d5c20afcc44a7..f6629e2d9dab35a872d226e2fb05c071eda30e51 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -2935,8 +2935,6 @@ void ArgumentsAccessStub::GenerateNewNonStrictSlow(MacroAssembler* masm) {
StandardFrameConstants::kCallerSPOffset));
__ mov(Operand(esp, 2 * kPointerSize), edx);
- // Try the new space allocation. Start out with computing the size of
- // the arguments object and the elements array.
__ bind(&runtime);
__ TailCallRuntime(Runtime::kNewArgumentsFast, 3, 1);
}
@@ -3139,11 +3137,13 @@ void ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
__ sub(Operand(edx), ebx); // Is there a smarter way to do negative scaling?
__ sub(Operand(edx), ebx);
__ jmp(&arguments_test, Label::kNear);
+
__ bind(&arguments_loop);
__ sub(Operand(edx), Immediate(kPointerSize));
__ mov(eax, Operand(edx, 0));
__ mov(FieldOperand(edi, ebx, times_2, FixedArray::kHeaderSize), eax);
__ add(Operand(ebx), Immediate(Smi::FromInt(1)));
+
__ bind(&arguments_test);
__ cmp(ebx, Operand(ecx));
__ j(less, &arguments_loop, Label::kNear);

Powered by Google App Engine
This is Rietveld 408576698