AXSubrole and AXRoleDescription is not exposed for HTML form element.

AXSubrole and AXRoleDescription is not exposed for HTML form element.

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html

HTML Form element should be exposed on MAC as below:
AXRole: AXGroup
AXSubrole: AXLandmarkForm
AXRoleDescription: "form"

This CL depends on blink side CL https://codereview.chromium.org/704083004/ for aria-form.html

BUG=430873
Committed: https://crrev.com/b70363420dbfe0825e96e3d025fb0bacb26ff2f4
Cr-Commit-Position: refs/heads/master@{#303789}

[shreeramk, 2014-11-07 03:57:55]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[shreeramk, 2014-11-07 03:57:56]

The reason for failure of try bot is below:

DCHECK(!role_name_.empty() || ia_role_);

Solutions:
1. We can change the value of role_name_ under switch case ui::AX_ROLE_FORM, to
role_name_ = html_Tag

2. Or can't ia2_role_ can be included in DCHECK condition??

[dmazzoni, 2014-11-08 00:43:55]

On 2014/11/07 03:57:56, shreeramk wrote:
> The reason for failure of try bot is below:
> 
> DCHECK(!role_name_.empty() || ia_role_);
> 
> Solutions:
> 1. We can change the value of role_name_ under switch case ui::AX_ROLE_FORM,
to
> role_name_ = html_Tag
> 
> 2. Or can't ia2_role_ can be included in DCHECK condition??

[dmazzoni, 2014-11-08 00:45:46]

On 2014/11/07 03:57:56, shreeramk wrote:
> The reason for failure of try bot is below:
> 
> DCHECK(!role_name_.empty() || ia_role_);
> 
> Solutions:
> 1. We can change the value of role_name_ under switch case ui::AX_ROLE_FORM,
to
> role_name_ = html_Tag
> 
> 2. Or can't ia2_role_ can be included in DCHECK condition??

The reason for the check failure is because we need to support clients that only
use the IAccessible interface and don't check IAccessible2. So we have to return
a ia_role_.

Idea #1 looks right - set role_name_ to the html tag.

[dmazzoni, 2014-11-08 00:47:13]

On 2014/11/08 00:45:46, dmazzoni wrote:
> On 2014/11/07 03:57:56, shreeramk wrote:
> > The reason for failure of try bot is below:
> > 
> > DCHECK(!role_name_.empty() || ia_role_);
> > 
> > Solutions:
> > 1. We can change the value of role_name_ under switch case ui::AX_ROLE_FORM,
> to
> > role_name_ = html_Tag
> > 
> > 2. Or can't ia2_role_ can be included in DCHECK condition??
> 
> The reason for the check failure is because we need to support clients that
only
> use the IAccessible interface and don't check IAccessible2. So we have to
return
> a ia_role_.
> 
> Idea #1 looks right - set role_name_ to the html tag.

Oh wait, this is for an ARIA role of form, so that won't work.

Either put it back to role_name_ = "form", or use a generic ia_role_ like
ROLE_SYSTEM_GROUPING or something like that.

[dmazzoni, 2014-11-08 00:48:10]

lgtm

lgtm once that change is addressed

[shreeramk, 2014-11-08 10:41:10]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-11-08 10:41:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702393002/100001

[commit-bot: I haz the power, 2014-11-08 10:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-08 10:45:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shreeramk, 2014-11-08 11:33:28]

shreeram.k@samsung.com changed reviewers:
+ avi@chromium.org

[shreeramk, 2014-11-08 11:33:59]

On 2014/11/08 10:45:38, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

@Avi: Please review changes in content_strings.grd

Thanks!

[shreeramk, 2014-11-11 06:58:05]

@Avi: Please review the changes in content_strings.grd.

Thanks!!

[Avi (use Gerrit), 2014-11-11 18:04:11]

if dmazzoni is happy then so am I

stampity stamp LGTM

[shreeramk, 2014-11-12 05:01:05]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-11-12 05:02:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702393002/100001

[commit-bot: I haz the power, 2014-11-12 05:04:40]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-12 05:05:16]

Patchset 6 (id:??) landed as
https://crrev.com/b70363420dbfe0825e96e3d025fb0bacb26ff2f4
Cr-Commit-Position: refs/heads/master@{#303789}