Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 702353002: downloads: add "No downloads" and "No search results" messages. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
benjhayden
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org, bondd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

downloads: add "No downloads" and "No search results" messages. R=benjhayden@chromium.org BUG=428025 Committed: https://crrev.com/cf9ab04039fc3c7b38305567082d3f6733272fec Cr-Commit-Position: refs/heads/master@{#303090}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : benjhayden@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/downloads/downloads.css View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/resources/downloads/downloads.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/downloads/downloads.js View 1 2 7 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui_browsertest.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Dan Beam
6 years, 1 month ago (2014-11-06 05:28:27 UTC) #1
benjhayden
Assuming you ran the tests and the page LGTY, one minor nit then LGTM. https://codereview.chromium.org/702353002/diff/20001/chrome/browser/resources/downloads/downloads.js ...
6 years, 1 month ago (2014-11-06 16:59:54 UTC) #2
Dan Beam
https://codereview.chromium.org/702353002/diff/20001/chrome/browser/resources/downloads/downloads.js File chrome/browser/resources/downloads/downloads.js (right): https://codereview.chromium.org/702353002/diff/20001/chrome/browser/resources/downloads/downloads.js#newcode196 chrome/browser/resources/downloads/downloads.js:196: if (!this.noDownloadsOrResults_.hidden) { On 2014/11/06 16:59:54, benjhayden_chromium wrote: > ...
6 years, 1 month ago (2014-11-06 19:57:52 UTC) #3
benjhayden
lgtm
6 years, 1 month ago (2014-11-06 19:59:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702353002/40001
6 years, 1 month ago (2014-11-06 20:09:51 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-06 21:09:36 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 21:10:14 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cf9ab04039fc3c7b38305567082d3f6733272fec
Cr-Commit-Position: refs/heads/master@{#303090}

Powered by Google App Engine
This is Rietveld 408576698