Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 70233017: ozone: Disable tests that create multiple RootWindowHosts (Closed)

Created:
7 years, 1 month ago by spang
Modified:
7 years, 1 month ago
Reviewers:
kalyank, sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

ozone: Disable tests that create multiple RootWindowHosts BUG=319986 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235670

Patch Set 1 #

Total comments: 3

Patch Set 2 : add comment to disabled tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M ui/aura/root_window_unittest.cc View 1 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
spang
7 years, 1 month ago (2013-11-15 20:36:51 UTC) #1
spang
7 years, 1 month ago (2013-11-15 20:37:03 UTC) #2
kalyank
https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc#newcode1184 ui/aura/root_window_unittest.cc:1184: #if defined(USE_OZONE) Shouldn't we do this only when views ...
7 years, 1 month ago (2013-11-15 20:41:25 UTC) #3
spang
On 2013/11/15 20:41:25, kalyank wrote: > https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc > File ui/aura/root_window_unittest.cc (right): > > https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc#newcode1184 > ...
7 years, 1 month ago (2013-11-15 21:09:52 UTC) #4
sadrul
lgtm https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc#newcode1185 ui/aura/root_window_unittest.cc:1185: #define MAYBE_ValidRootDuringDestruction DISABLED_ValidRootDuringDestruction You should add a comment ...
7 years, 1 month ago (2013-11-15 22:36:36 UTC) #5
spang
https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/70233017/diff/1/ui/aura/root_window_unittest.cc#newcode1185 ui/aura/root_window_unittest.cc:1185: #define MAYBE_ValidRootDuringDestruction DISABLED_ValidRootDuringDestruction On 2013/11/15 22:36:37, sadrul wrote: > ...
7 years, 1 month ago (2013-11-15 22:48:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/70233017/70001
7 years, 1 month ago (2013-11-15 22:56:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/70233017/70001
7 years, 1 month ago (2013-11-16 00:56:53 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 08:41:44 UTC) #9
Message was sent while issue was closed.
Change committed as 235670

Powered by Google App Engine
This is Rietveld 408576698