API: Change AdjustAmountOfExternalAllocatedMemory calls to use int64_t instead of intptr_t

API: Change AdjustAmountOfExternalAllocatedMemory calls to use int64_t instead
of intptr_t

This prevents an overflow in FreeArrayBuffer, which in turn caused needless GCs
as well as crashes on isolate teardown.

LOG=Y
R=ulan@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=17944

[Jakob Kummerow, 2013-11-14 14:37:41]

PTAL.

[ulan, 2013-11-14 14:47:50]

LGTM

[Sven Panne, 2013-11-15 07:21:30]

https://codereview.chromium.org/70233010/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/70233010/diff/1/include/v8.h#newcode4663
include/v8.h:4663: static int64_t AdjustAmountOfExternalAllocatedMemory(
This will break 32bit embedders, so we either leave it as it is or completely
remove the API entry. Breaking things which are V8_DEPRECATED is not the way to
go...

[Jakob Kummerow, 2013-11-18 17:02:02]

As discussed offline, embedders only require code changes if they store the
result of an AdjustAmountOfExternalAllocatedMemory call in a 32bit integer.
Chromium at least doesn't do that. Otherwise, a simple recompile is sufficient
(and we don't promise binary compatibility anyways).
Also, the existing API is inherently broken and can easily cause misbehavior
(GCs not happening when they should, and happening when they should not) as well
as crashes on shutdown. If I change the CL description to the following, would
that make you happy?

"API: Change AdjustAmountOfExternalAllocatedMemory calls to use int64_t instead
of intptr_t

This prevents an overflow in FreeArrayBuffer, which in turn caused needless GCs
as well as crashes on isolate teardown.

LOG=Y"

[Jakob Kummerow, 2013-11-21 08:06:16]

Committed patchset #1 manually as r17944 (presubmit successful).