Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 702323002: Change default button on delete user confirmation page (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
dcheng
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change default button on delete user confirmation page. Also makes sync setup overlay act like the rest of webui (class=default-button instead .focus()). BUG=427937 R=dcheng@chromium.org TEST="Remove..." a profile, "Cancel" should be the default dialog button Committed: https://crrev.com/095765d9c75846dc4a6104e86a0412a3d68b506b Cr-Commit-Position: refs/heads/master@{#303254}

Patch Set 1 #

Patch Set 2 : shaving #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -41 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.html View 1 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.js View 1 8 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Dan Beam
6 years, 1 month ago (2014-11-06 00:12:43 UTC) #1
dcheng
What about chrome/browser/resources/sync_setup_overlay.html, where the default is set using JS?
6 years, 1 month ago (2014-11-06 22:44:28 UTC) #2
Dan Beam
On 2014/11/06 22:44:28, dcheng wrote: > What about chrome/browser/resources/sync_setup_overlay.html, where the default > is set ...
6 years, 1 month ago (2014-11-07 04:59:51 UTC) #4
dcheng
lgtm
6 years, 1 month ago (2014-11-07 07:15:05 UTC) #5
dcheng
lgtm
6 years, 1 month ago (2014-11-07 07:15:07 UTC) #6
dcheng
(Oops on the double lgtm. I think the CL description needs a minor update)
6 years, 1 month ago (2014-11-07 07:15:29 UTC) #7
Dan Beam
On 2014/11/07 07:15:29, dcheng wrote: > (Oops on the double lgtm. I think the CL ...
6 years, 1 month ago (2014-11-07 17:06:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702323002/40001
6 years, 1 month ago (2014-11-07 17:07:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-07 17:53:43 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 17:54:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/095765d9c75846dc4a6104e86a0412a3d68b506b
Cr-Commit-Position: refs/heads/master@{#303254}

Powered by Google App Engine
This is Rietveld 408576698