Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 702243003: Basic array capacity feedback via allocation sites.

Created:
6 years, 1 month ago by mvstanton
Modified:
4 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Basic array capacity feedback via allocation sites. Caveats: * Gathers feedback in full code, bakes in only in optimized code. * Only works for these cases: new Array(); new Array(<0 <= constant <= 8>); and not for new Array(arg1, arg2, ..., argN) or new Array(non-constant length) Also (as if that wasn't enough) * Only gathers feedback on calls to array.push on SMI or FAST arrays which are handled by the C++ runtime. BUG=

Patch Set 1 #

Patch Set 2 : Small benchmark. #

Patch Set 3 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -16 lines) Patch
M src/builtins.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/elements.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 2 4 chunks +44 lines, -8 lines 0 comments Download
M src/objects.h View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 2 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
mvstanton
6 years, 1 month ago (2014-11-05 22:29:27 UTC) #2
Hi guys,
Here is the experiment with array capacity feedback thus far. It works modulo a
few caveats :p.
--Michael

Powered by Google App Engine
This is Rietveld 408576698