Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 702173002: [Telemetry] Add browser option that allows disabling crash service (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years, 1 month ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add browser option that allows disabling crash service TBR=dtu@chromium.org BUG=430246 Committed: https://crrev.com/797b1a69e4a74be52c6a3841547072321b297a7f Cr-Commit-Position: refs/heads/master@{#302903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
nednguyen
6 years, 1 month ago (2014-11-05 18:03:39 UTC) #2
Ken Russell (switch to Gerrit)
LGTM. Thanks. This flag might be useful in the future for debugging and I think ...
6 years, 1 month ago (2014-11-05 19:13:19 UTC) #3
nednguyen
On 2014/11/05 19:13:19, Ken Russell wrote: > LGTM. Thanks. > > This flag might be ...
6 years, 1 month ago (2014-11-05 21:58:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702173002/1
6 years, 1 month ago (2014-11-05 22:01:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 23:44:36 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/797b1a69e4a74be52c6a3841547072321b297a7f Cr-Commit-Position: refs/heads/master@{#302903}
6 years, 1 month ago (2014-11-05 23:45:18 UTC) #8
nednguyen
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/721443006/ by nednguyen@google.com. ...
6 years, 1 month ago (2014-11-17 19:46:37 UTC) #9
nednguyen
6 years, 1 month ago (2014-11-17 20:02:05 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/738483002/ by nednguyen@google.com.

The reason for reverting is: Bug 424024 is marked fixed. Crash service was not
the reason of the flakiness.

Note: first revert attempt was reverted
(https://codereview.chromium.org/721443006/).

Powered by Google App Engine
This is Rietveld 408576698