Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 702113002: Switch DEPS to git. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Review. #

Patch Set 5 : More review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -133 lines) Patch
D .DEPS.git View 1 chunk +0 lines, -113 lines 0 comments Download
M DEPS View 1 2 3 4 1 chunk +9 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
Michael Achenbach
PTAL. To land on flag day.
6 years, 1 month ago (2014-11-05 15:26:28 UTC) #2
tandrii(chromium)
this patch will probably need a rebase, which will not be ff, so maybe just ...
6 years, 1 month ago (2014-11-05 15:28:39 UTC) #3
agable
On 2014/11/05 at 15:28:39, tandrii wrote: > this patch will probably need a rebase, which ...
6 years, 1 month ago (2014-11-05 19:17:40 UTC) #4
Michael Achenbach
I actually just copied the .DEPS.git that we had lying around. Maybe somebody kept it ...
6 years, 1 month ago (2014-11-05 21:47:19 UTC) #5
agable
On 2014/11/05 at 21:47:19, machenbach wrote: > I actually just copied the .DEPS.git that we ...
6 years, 1 month ago (2014-11-06 19:26:01 UTC) #6
agable
On 2014/11/06 at 19:26:01, agable wrote: > On 2014/11/05 at 21:47:19, machenbach wrote: > > ...
6 years, 1 month ago (2014-11-10 18:16:23 UTC) #7
tandrii(chromium)
what's the reason for landing *before* wednesday? Is to make sure slaves pick this up ...
6 years, 1 month ago (2014-11-10 18:18:33 UTC) #8
agable
On 2014/11/10 at 18:18:33, tandrii wrote: > what's the reason for landing *before* wednesday? > ...
6 years, 1 month ago (2014-11-11 18:31:37 UTC) #9
agable
https://codereview.chromium.org/702113002/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/702113002/diff/40001/DEPS#newcode2 DEPS:2: 'webkit_url': This isn't used.
6 years, 1 month ago (2014-11-11 20:12:06 UTC) #10
Michael Achenbach
All done. Kept the exact formatting as before (despite inconsistent commas, order and white space). ...
6 years, 1 month ago (2014-11-11 22:05:58 UTC) #11
Michael Achenbach
6 years, 1 month ago (2014-11-11 22:07:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 25274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698