Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 702093002: Convert fast/multicol/positioned-split to reftest. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/positioned-split to reftest. * Set explicit column-gap and line-height. * Clarified pass condition. * Removed useless evil twin in fast/multicol/newmulticol. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -144 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/positioned-split.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/positioned-split-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/multicol/positioned-split.html View 1 chunk +32 lines, -12 lines 0 comments Download
A LayoutTests/fast/multicol/positioned-split-expected.html View 1 chunk +33 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/positioned-split-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/positioned-split-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/positioned-split-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/positioned-split-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/positioned-split-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/positioned-split-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/positioned-split-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/positioned-split-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
andersr
6 years, 1 month ago (2014-11-05 15:02:18 UTC) #1
mstensho (USE GERRIT)
lgtm
6 years, 1 month ago (2014-11-06 14:18:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702093002/1
6 years, 1 month ago (2014-11-07 10:00:17 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 12:51:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184967

Powered by Google App Engine
This is Rietveld 408576698