Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 702083004: Add a --recursive flag to compare_build_artifacts and always look at the content of the *_apk subdi… (Closed)

Created:
6 years, 1 month ago by Sébastien Marchand
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Add a --recursive flag to compare_build_artifacts and always look at the content of the *_apk subdirs. The new flag makes the debugging much faster when the .isolated refers to some files that are not in the product directory. On Android the apks are not in the product directory, they're in a directory called $(test_name)_apk/ (e.g. net_unittests_apk/net_unittests.apk) BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 6 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
PTAL.
6 years, 1 month ago (2014-11-05 17:37:26 UTC) #2
M-A Ruel
lgtm
6 years, 1 month ago (2014-11-05 17:41:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702083004/1
6 years, 1 month ago (2014-11-05 17:43:11 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 17:43:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292850

Powered by Google App Engine
This is Rietveld 408576698