Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 702083003: Add mock context and use in ResourceCacheTest. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : test- #

Total comments: 4

Patch Set 3 : Address comments #

Patch Set 4 : update #

Patch Set 5 : restore removed null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -71 lines) Patch
M include/gpu/GrContext.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 1 chunk +135 lines, -0 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 10 chunks +83 lines, -63 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
bsalomon
6 years, 1 month ago (2014-11-05 16:49:20 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/702083003/diff/20001/src/gpu/GrTest.cpp File src/gpu/GrTest.cpp (right): https://codereview.chromium.org/702083003/diff/20001/src/gpu/GrTest.cpp#newcode154 src/gpu/GrTest.cpp:154: GrContext* GrContext::CreateMockContext() { One line ? ...
6 years, 1 month ago (2014-11-05 18:12:00 UTC) #3
bsalomon
https://codereview.chromium.org/702083003/diff/20001/src/gpu/GrTest.cpp File src/gpu/GrTest.cpp (right): https://codereview.chromium.org/702083003/diff/20001/src/gpu/GrTest.cpp#newcode154 src/gpu/GrTest.cpp:154: GrContext* GrContext::CreateMockContext() { On 2014/11/05 18:12:00, robertphillips wrote: > ...
6 years, 1 month ago (2014-11-05 19:44:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702083003/40001
6 years, 1 month ago (2014-11-05 19:45:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/451) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/453) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot ...
6 years, 1 month ago (2014-11-05 19:47:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702083003/60001
6 years, 1 month ago (2014-11-05 19:56:49 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 820dd6c335411aad889c1d7e8a857642ecd87e30
6 years, 1 month ago (2014-11-05 20:09:53 UTC) #11
bsalomon
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/704563004/ by bsalomon@google.com. ...
6 years, 1 month ago (2014-11-05 20:29:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702083003/80001
6 years, 1 month ago (2014-11-05 22:39:34 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 22:47:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 334355742137cc238887d4f85856e6c4d9ec8aa8

Powered by Google App Engine
This is Rietveld 408576698