Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 70203002: Simplify Hydrogen code stubs with variable argument count (Closed)

Created:
7 years, 1 month ago by mvstanton
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest, danno
CC:
v8-dev
Visibility:
Public.

Description

Simplify behavior of code stubs that accept a variable number of stack arguments in addition to their parameters. Before, we'd add a special variable to the environment with the value of a register with the number of arguments. Now, that register just appears as a parameter to the code stub. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17680

Patch Set 1 #

Patch Set 2 : Removed smi-ification of variable arg count #

Total comments: 1

Patch Set 3 : Ports, small nits. #

Patch Set 4 : Removed TRANSLATED_VALUE_IS_NATIVE #

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -111 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 2 chunks +21 lines, -8 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 4 3 chunks +23 lines, -11 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 4 2 chunks +17 lines, -18 lines 0 comments Download
M src/deoptimizer.h View 1 2 3 4 1 chunk +2 lines, -8 lines 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 12 chunks +36 lines, -38 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 2 chunks +20 lines, -8 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 2 3 4 2 chunks +18 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 2 chunks +21 lines, -8 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Toon, Danno, PTAL, --Michael
7 years, 1 month ago (2013-11-12 15:33:20 UTC) #1
Toon Verwaest
https://codereview.chromium.org/70203002/diff/30001/src/deoptimizer.cc File src/deoptimizer.cc (left): https://codereview.chromium.org/70203002/diff/30001/src/deoptimizer.cc#oldcode1548 src/deoptimizer.cc:1548: TRANSLATED_VALUE_IS_NATIVE); Now we can get rid of TRANSLATED_VALUE_IS_NATIVE I ...
7 years, 1 month ago (2013-11-12 15:43:05 UTC) #2
mvstanton
Thx, updated.
7 years, 1 month ago (2013-11-12 15:51:27 UTC) #3
Toon Verwaest
lgtm
7 years, 1 month ago (2013-11-12 15:53:37 UTC) #4
mvstanton
7 years, 1 month ago (2013-11-13 10:07:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r17680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698