Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: BUILD.gn

Issue 702003002: Make *some* version of the Mac GN build work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: skip //chrome/tests on mac and win Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | breakpad/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index da53c4ee5156e0c0575cb1d91b6d7f2129d2ad9b..3b155cfc1094d02ea330727a1d7f957ee1dc2e01 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -200,6 +200,12 @@ group("root") {
]
}
+ # TODO(GYP): Move the targets in the rest of this block that still
+ # need to be made to work in the GN build to the bottom of the file
+ # so that all the remaining work is located in one place in the file.
+ # This block should contain only the targets that aren't actually
+ # needed on Android.
+
deps -= [
"//apps", # Needs testing.
"//chrome/browser",
@@ -260,8 +266,63 @@ group("root") {
]
}
+ #
+ # TODO(GYP): Make everything below this work in the GN build.
+ #
+
+ if (is_mac) {
+ # TODO(dpranke): Need to fix the unused function errors in breakpad.
+ deps -= [
+ "//breakpad:symupload"
+ ]
+
+ # TODO(dpranke): These need a webrtc fix in order to build.
+ deps -= [
+ "//jingle:notifier",
+ "//third_party/libjingle",
+ "//third_party/webrtc",
+ ]
+
+ # TODO(dpranke): These depend on Blink and need Blink fixes to build.
+ deps -= [
+ "//cc/blink",
+ "//content",
+ "//content/test:test_support",
+ "//media/blink",
+ "//pdf",
+ "//ppapi:ppapi_c",
+ "//third_party/WebKit/public:all_blink",
+ "//ui/app_list",
+ ]
+
+ # TODO(dpranke): These are as-yet untriaged but need at least the above.
+ deps -= [
+ "//apps",
+ "//ash",
+ "//chrome/browser",
+ "//chrome/browser/devtools",
+ "//chrome/common",
+ "//chrome/plugin",
+ "//chrome/renderer",
+ "//chrome/test",
+ "//chrome/utility",
+ "//components:all_components",
+ "//content/shell:content_shell",
+ "//extensions/browser",
+ "//extensions/common",
+ "//extensions/common/api",
+ "//extensions/renderer",
+ "//remoting/client/plugin",
+ "//third_party/usrsctp",
+ "//ui/aura",
+ "//ui/keyboard",
+ "//ui/views",
+ "//ui/views/controls/webview",
+ "//ui/web_dialogs",
+ ]
+ }
+
if (is_win) {
- # TODO(GYP): Make these work.
deps -= [
"//apps",
"//ash",
@@ -270,6 +331,7 @@ group("root") {
"//chrome/common",
"//chrome/plugin",
"//chrome/renderer",
+ "//chrome/test",
"//chrome/utility",
"//components:all_components",
"//cc",
« no previous file with comments | « no previous file | breakpad/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698