Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: breakpad/BUILD.gn

Issue 702003002: Make *some* version of the Mac GN build work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to r303398 (after win gn CL landed) Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 56a2acb8f40467a6ff0d9f6294fcbb191ef1964f..5372d2b85243698fe920ffedab0a4f8b150e9015 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -222,7 +222,11 @@ if (current_toolchain == host_toolchain && is_mac) {
"src/tools/mac/symupload/symupload.m",
]
- libs = [ "Foundaction.framework" ]
+ include_dirs = [
+ "src/common/mac"
+ ]
+
+ libs = [ "Foundation.framework" ]
}
}
@@ -250,6 +254,11 @@ if (is_mac) {
]
configs += [ ":internal_config" ]
+
+ # TODO(GYP): TODO(dpranke): Fix the compile for this.
+ sources -= [
+ "src/client/mac/handler/dynamic_images.cc",
+ ]
}
executable("crash_inspector") {
@@ -275,9 +284,9 @@ if (is_mac) {
]
}
- executable("crash_report_sender") {
- # TODO(GYP) this target has some mac_bundle_resources stuff.
- }
+ # TODO(GYP) this target has some mac_bundle_resources stuff.
+ # executable("crash_report_sender") {
+ # }
config("breakpad_config") {
include_dirs = [ "src/client/apple/Framework" ]
« no previous file with comments | « BUILD.gn ('k') | mojo/services/BUILD.gn » ('j') | mojo/services/html_viewer/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698