Issue 7020011: disable timing tests on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7020011: disable timing tests on windows. (Closed)

Created:
9 years, 6 months ago by bsy

Modified:
9 years, 6 months ago

Reviewers:
jasonwkim

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

disable timing tests on windows. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1736 TEST= this is a test Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5520

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	tests/nanosleep/nacl.scons	View		3 chunks	+5 lines, -1 line	2 comments	Download
	M	tests/syscalls/nacl.scons	View		3 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jasonwkim

On 2011/05/31 23:26:27, bsy wrote: LGTM with is_on_vm check for all timing tests. Thanks!!

9 years, 6 months ago (2011-06-01 17:38:24 UTC) #2

jasonwkim

http://codereview.chromium.org/7020011/diff/1/tests/nanosleep/nacl.scons File tests/nanosleep/nacl.scons (right): http://codereview.chromium.org/7020011/diff/1/tests/nanosleep/nacl.scons#newcode33 tests/nanosleep/nacl.scons:33: is_broken=is_broken or test_is_broken_on_this_os) What about is_on_vm?

9 years, 6 months ago (2011-06-01 17:38:32 UTC) #3

bsy

9 years, 6 months ago (2011-06-01 18:21:16 UTC) #4

http://codereview.chromium.org/7020011/diff/1/tests/nanosleep/nacl.scons
File tests/nanosleep/nacl.scons (right):

http://codereview.chromium.org/7020011/diff/1/tests/nanosleep/nacl.scons#newc...
tests/nanosleep/nacl.scons:33: is_broken=is_broken or test_is_broken_on_this_os)
On 2011/06/01 17:38:32, jasonwkim wrote:
> What about is_on_vm?

renamed here and on line 27.

Expand Messages | Collapse Messages