Issue 701983003: Upstream iOS Translate strings

Issue 701983003: Upstream iOS Translate strings (Closed)

Created:
6 years, 1 month ago by droger

Modified:
6 years, 1 month ago

Reviewers:
msarda

CC:
chromium-reviews, bzanotti, rohitrao (ping after 24h)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Upstream iOS Translate strings This CL also updates the whitelist to the current version. BUG=430443 Committed: https://crrev.com/b57affff6056db7e5d97382fbd787f5a31d121e7 Cr-Commit-Position: refs/heads/master@{#302838}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -9 lines)			Patch
	M	build/ios/grit_whitelist.txt	View	1	38 chunks	+167 lines, -6 lines	0 comments	Download
	M	components/translate_strings.grdp	View		4 chunks	+13 lines, -3 lines	0 comments	Download

Total messages: 9 (2 generated)

droger

Do you think we need a comment in generated_resources.grd, to prevent being deleted?

6 years, 1 month ago (2014-11-05 14:44:40 UTC) #2

droger

I removed the app launcher strings. This is now only about translate.

6 years, 1 month ago (2014-11-05 15:14:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701983003/20001

6 years, 1 month ago (2014-11-05 18:05:36 UTC) #7

commit-bot: I haz the power

6 years, 1 month ago (2014-11-05 18:52:37 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b57affff6056db7e5d97382fbd787f5a31d121e7
Cr-Commit-Position: refs/heads/master@{#302838}