Separate checking the user identity and checking if the user is syncing his history in two differen…

chrome/browser/ui/search/search_ipc_router.cc

Index: chrome/browser/ui/search/search_ipc_router.cc
diff --git a/chrome/browser/ui/search/search_ipc_router.cc b/chrome/browser/ui/search/search_ipc_router.cc
index c81a1e99229a4ff3346a81b537cd20bde1bdc59f..f75ae1d43c52090cbf1bd6bd69a9adb529c5bd27 100644
--- a/chrome/browser/ui/search/search_ipc_router.cc
+++ b/chrome/browser/ui/search/search_ipc_router.cc
@@ -61,6 +61,14 @@ void SearchIPCRouter::SendChromeIdentityCheckResult(
                                                    identity_match));
 }
 
+void SearchIPCRouter::SendHistorySyncCheckResult(bool sync_history) {
+  if (!policy_->ShouldProcessHistorySyncCheck())
+    return;
+
+  Send(new ChromeViewMsg_HistorySyncCheckResult(routing_id(),
+                                                sync_history));

[kmadhusu, 2014/11/19 19:56:19]

style nit: sync_history can go to the previous line.

[beaudoin, 2014/11/20 22:58:26]

Done.

+}
+
 void SearchIPCRouter::SetPromoInformation(bool is_app_launcher_enabled) {
   if (!policy_->ShouldSendSetPromoInformation())
     return;
@@ -179,6 +187,8 @@ bool SearchIPCRouter::OnMessageReceived(const IPC::Message& message) {
                         OnLogMostVisitedNavigation);
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_PasteAndOpenDropdown,
                         OnPasteAndOpenDropDown);
+    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_HistorySyncCheck,
+                        OnHistorySyncCheck);
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_ChromeIdentityCheck,
                         OnChromeIdentityCheck);
     IPC_MESSAGE_UNHANDLED(handled = false)
@@ -332,6 +342,17 @@ void SearchIPCRouter::OnChromeIdentityCheck(
   delegate_->OnChromeIdentityCheck(identity);
 }
 
+void SearchIPCRouter::OnHistorySyncCheck(int page_seq_no) const {
+  if (page_seq_no != commit_counter_)
+    return;
+
+  delegate_->OnInstantSupportDetermined(true);

[dcheng, 2014/11/12 21:40:47]

I don't really understand how this works. Why does receiving this message imply
that this page must support instant?

[kmadhusu, 2014/11/19 19:56:19]

We handle this message only when the web contents are rendered in the Instant
Process (Ref: SearchIPCRouter::OnMessageReceived). NewTab contents are rendered
in the Instant process. Hence we know that the page supports Instant.

[beaudoin, 2014/11/20 22:58:26]

IIUC, all the API calls here are only performed when the NTP supports instant.
Whenever one of these is called we flip a bit to remember that we have an
instant-enabled NTP.

+  if (!policy_->ShouldProcessHistorySyncCheck())
+    return;
+
+  delegate_->OnHistorySyncCheck();
+}
+
 void SearchIPCRouter::set_delegate_for_testing(Delegate* delegate) {
   DCHECK(delegate);
   delegate_ = delegate;