Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3182)

Unified Diff: content/test/test_web_contents.h

Issue 701953006: PlzNavigate: Speculatively spawns a renderer process for navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR comments. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_web_contents.h
diff --git a/content/test/test_web_contents.h b/content/test/test_web_contents.h
index 8e3c2b55f382e97046ed300a1fbcd5cd4df6e19a..ac38f1654276553556fb70fe5ee93a3f23ec6436 100644
--- a/content/test/test_web_contents.h
+++ b/content/test/test_web_contents.h
@@ -94,6 +94,12 @@ class TestWebContents : public WebContentsImpl, public WebContentsTester {
int error_code,
const base::string16& error_description);
+ // Returns the same result as a call to GetPendingMainFrame.
nasko 2015/01/06 00:03:18 nit: If it returns the same result, then we don't
carlosk 2015/01/08 16:05:56 Updated the comment in that sense.
+ // PlzNavigate: when browser side navigation is enabled it returns the
+ // speculative RenderFrameHost for the main frame if one exists. Otherwise
+ // returns nullptr.
+ TestRenderFrameHost* GetFutureMainFrame() const;
nasko 2015/01/06 00:03:18 nit: I'm not a big fan of "Future" as it implies s
carlosk 2015/01/08 16:05:56 Well then... :) I changed it to GetNextMainFrameC
nasko 2015/01/08 23:36:37 Yes, I like this better! Thanks!
+
protected:
// The deprecated WebContentsTester still needs to subclass this.
explicit TestWebContents(BrowserContext* browser_context);

Powered by Google App Engine
This is Rietveld 408576698