Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 701953006: PlzNavigate: Speculatively spawns a renderer process for navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address CR comments.. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h"
5 #include "base/macros.h" 6 #include "base/macros.h"
6 #include "base/time/time.h" 7 #include "base/time/time.h"
7 #include "content/browser/frame_host/navigation_controller_impl.h" 8 #include "content/browser/frame_host/navigation_controller_impl.h"
8 #include "content/browser/frame_host/navigation_entry_impl.h" 9 #include "content/browser/frame_host/navigation_entry_impl.h"
9 #include "content/browser/frame_host/navigation_request.h" 10 #include "content/browser/frame_host/navigation_request.h"
10 #include "content/browser/frame_host/navigation_request_info.h" 11 #include "content/browser/frame_host/navigation_request_info.h"
11 #include "content/browser/frame_host/navigator.h" 12 #include "content/browser/frame_host/navigator.h"
12 #include "content/browser/frame_host/navigator_impl.h" 13 #include "content/browser/frame_host/navigator_impl.h"
13 #include "content/browser/frame_host/render_frame_host_manager.h" 14 #include "content/browser/frame_host/render_frame_host_manager.h"
14 #include "content/browser/site_instance_impl.h" 15 #include "content/browser/site_instance_impl.h"
15 #include "content/browser/streams/stream.h" 16 #include "content/browser/streams/stream.h"
16 #include "content/common/navigation_params.h" 17 #include "content/common/navigation_params.h"
17 #include "content/public/browser/stream_handle.h" 18 #include "content/public/browser/stream_handle.h"
19 #include "content/public/common/content_switches.h"
18 #include "content/public/common/url_constants.h" 20 #include "content/public/common/url_constants.h"
19 #include "content/public/common/url_utils.h" 21 #include "content/public/common/url_utils.h"
22 #include "content/public/test/mock_render_process_host.h"
20 #include "content/test/browser_side_navigation_test_utils.h" 23 #include "content/test/browser_side_navigation_test_utils.h"
21 #include "content/test/test_navigation_url_loader.h" 24 #include "content/test/test_navigation_url_loader.h"
22 #include "content/test/test_render_frame_host.h" 25 #include "content/test/test_render_frame_host.h"
23 #include "content/test/test_web_contents.h" 26 #include "content/test/test_web_contents.h"
24 #include "net/base/load_flags.h" 27 #include "net/base/load_flags.h"
25 #include "net/http/http_response_headers.h" 28 #include "net/http/http_response_headers.h"
26 #include "net/url_request/redirect_info.h" 29 #include "net/url_request/redirect_info.h"
27 #include "ui/base/page_transition_types.h" 30 #include "ui/base/page_transition_types.h"
28 #include "url/url_constants.h" 31 #include "url/url_constants.h"
29 32
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 controller().GetBrowserContext()))); 69 controller().GetBrowserContext())));
67 static_cast<NavigatorImpl*>(node->navigator())->RequestNavigation( 70 static_cast<NavigatorImpl*>(node->navigator())->RequestNavigation(
68 node, *entry, reload_type, base::TimeTicks::Now()); 71 node, *entry, reload_type, base::TimeTicks::Now());
69 } 72 }
70 73
71 NavigationRequest* GetNavigationRequestForFrameTreeNode( 74 NavigationRequest* GetNavigationRequestForFrameTreeNode(
72 FrameTreeNode* frame_tree_node) { 75 FrameTreeNode* frame_tree_node) {
73 return static_cast<NavigatorImpl*>(frame_tree_node->navigator()) 76 return static_cast<NavigatorImpl*>(frame_tree_node->navigator())
74 ->GetNavigationRequestForNodeForTesting(frame_tree_node); 77 ->GetNavigationRequestForNodeForTesting(frame_tree_node);
75 } 78 }
79
80 TestRenderFrameHost* GetSpeculativeRenderFrameHost(FrameTreeNode* node) {
81 return static_cast<TestRenderFrameHost*>(
82 node->render_manager()->speculative_render_frame_host_.get());
83 }
84
85 // Checks if this RenderFrameHost sent a single FrameMsg_CommitNavigation
86 // since the last clearing of the sink.
87 // Note: caller must invoke ClearMessages on the sink at some point before
88 // the tracked commit happens to clear up commit messages from previous
89 // navigations.
90 bool DidRenderFrameHostCommit(RenderFrameHostImpl* rfh) {
91 MockRenderProcessHost* rph =
92 static_cast<MockRenderProcessHost*>(rfh->GetProcess());
93 const FrameMsg_CommitNavigation* commit_message =
94 static_cast<const FrameMsg_CommitNavigation*>(
95 rph->sink().GetUniqueMessageMatching(
96 FrameMsg_CommitNavigation::ID));
97 return commit_message &&
98 rfh->GetRoutingID() == commit_message->routing_id();
99 }
76 }; 100 };
77 101
102 // PlzNavigate: Test final state after a complete navigation (to avoid repeating
103 // these checks in other tests).
104 TEST_F(NavigatorTestWithBrowserSideNavigation, NavigationFinishedState) {
105 const GURL kUrl("http://chromium.org/");
106 contents()->NavigateAndCommit(kUrl);
107 ASSERT_TRUE(main_test_rfh());
108 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, main_test_rfh()->rfh_state());
109 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl),
110 main_test_rfh()->GetSiteInstance()->GetSiteURL());
111
112 // After a navigation is finished no speculative RenderFrameHost should
113 // exist.
114 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
115 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
116
117 // With PlzNavigate enabled a pending RenderFrameHost should never exist.
118 EXPECT_FALSE(node->render_manager()->pending_frame_host());
119 }
120
78 // PlzNavigate: Test that a proper NavigationRequest is created by 121 // PlzNavigate: Test that a proper NavigationRequest is created by
79 // BeginNavigation. 122 // BeginNavigation.
80 // Note that all PlzNavigate methods on the browser side require the use of the 123 // Note that all PlzNavigate methods on the browser side require the use of the
81 // flag kEnableBrowserSideNavigation. 124 // flag kEnableBrowserSideNavigation.
82 TEST_F(NavigatorTestWithBrowserSideNavigation, BeginNavigation) { 125 TEST_F(NavigatorTestWithBrowserSideNavigation, BeginNavigation) {
83 const GURL kUrl1("http://www.google.com/"); 126 const GURL kUrl1("http://www.google.com/");
84 const GURL kUrl2("http://www.chromium.org/"); 127 const GURL kUrl2("http://www.chromium.org/");
85 const GURL kUrl3("http://www.gmail.com/"); 128 const GURL kUrl3("http://www.gmail.com/");
86 129
87 contents()->NavigateAndCommit(kUrl1); 130 contents()->NavigateAndCommit(kUrl1);
88 131
89 // Add a subframe. 132 // Add a subframe.
90 FrameTreeNode* root = contents()->GetFrameTree()->root(); 133 FrameTreeNode* root_node = contents()->GetFrameTree()->root();
91 TestRenderFrameHost* subframe_rfh = static_cast<TestRenderFrameHost*>( 134 TestRenderFrameHost* subframe_rfh =
92 contents()->GetFrameTree()->AddFrame( 135 static_cast<TestRenderFrameHost*>(contents()->GetFrameTree()->AddFrame(
93 root, root->current_frame_host()->GetProcess()->GetID(), 14, 136 root_node, root_node->current_frame_host()->GetProcess()->GetID(), 14,
94 "Child")); 137 "Child"));
95 EXPECT_TRUE(subframe_rfh); 138 ASSERT_TRUE(subframe_rfh);
96 139
97 FrameTreeNode* subframe_node = subframe_rfh->frame_tree_node(); 140 FrameTreeNode* subframe_node = subframe_rfh->frame_tree_node();
98 SendRequestNavigation(subframe_rfh->frame_tree_node(), kUrl2); 141 SendRequestNavigation(subframe_node, kUrl2);
99 // There is no previous renderer in the subframe, so BeginNavigation is 142 // There is no previous renderer in the subframe, so BeginNavigation is
100 // handled already. 143 // handled already.
101 NavigationRequest* subframe_request = 144 NavigationRequest* subframe_request =
102 GetNavigationRequestForFrameTreeNode(subframe_node); 145 GetNavigationRequestForFrameTreeNode(subframe_node);
103 TestNavigationURLLoader* subframe_loader = 146 TestNavigationURLLoader* subframe_loader =
104 GetLoaderForNavigationRequest(subframe_request); 147 GetLoaderForNavigationRequest(subframe_request);
105 ASSERT_TRUE(subframe_request); 148 ASSERT_TRUE(subframe_request);
106 EXPECT_EQ(kUrl2, subframe_request->common_params().url); 149 EXPECT_EQ(kUrl2, subframe_request->common_params().url);
107 EXPECT_EQ(kUrl2, subframe_loader->common_params().url); 150 EXPECT_EQ(kUrl2, subframe_loader->common_params().url);
108 // First party for cookies url should be that of the main frame. 151 // First party for cookies url should be that of the main frame.
109 EXPECT_EQ(kUrl1, subframe_loader->request_info()->first_party_for_cookies); 152 EXPECT_EQ(kUrl1, subframe_loader->request_info()->first_party_for_cookies);
110 EXPECT_FALSE(subframe_loader->request_info()->is_main_frame); 153 EXPECT_FALSE(subframe_loader->request_info()->is_main_frame);
111 EXPECT_TRUE(subframe_loader->request_info()->parent_is_main_frame); 154 EXPECT_TRUE(subframe_loader->request_info()->parent_is_main_frame);
155 EXPECT_FALSE(GetSpeculativeRenderFrameHost(root_node));
112 156
113 SendRequestNavigation(root, kUrl3); 157 // Subframe navigations should never create a speculative RenderFrameHost,
158 // unless site-per-process is enabled. In that case as the subframe navigation
159 // is to a different site and is still ongoing, it should have one.
160 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
161 switches::kSitePerProcess)) {
162 EXPECT_TRUE(GetSpeculativeRenderFrameHost(subframe_node));
163 } else {
164 EXPECT_FALSE(GetSpeculativeRenderFrameHost(subframe_node));
165 }
166
167 SendRequestNavigation(root_node, kUrl3);
114 // Simulate a BeginNavigation IPC on the main frame. 168 // Simulate a BeginNavigation IPC on the main frame.
115 contents()->GetMainFrame()->SendBeginNavigationWithURL(kUrl3); 169 main_test_rfh()->SendBeginNavigationWithURL(kUrl3);
116 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(root); 170 NavigationRequest* main_request =
171 GetNavigationRequestForFrameTreeNode(root_node);
117 TestNavigationURLLoader* main_loader = 172 TestNavigationURLLoader* main_loader =
118 GetLoaderForNavigationRequest(main_request); 173 GetLoaderForNavigationRequest(main_request);
119 ASSERT_TRUE(main_request); 174 ASSERT_TRUE(main_request);
120 EXPECT_EQ(kUrl3, main_request->common_params().url); 175 EXPECT_EQ(kUrl3, main_request->common_params().url);
121 EXPECT_EQ(kUrl3, main_loader->common_params().url); 176 EXPECT_EQ(kUrl3, main_loader->common_params().url);
122 EXPECT_EQ(kUrl3, main_loader->request_info()->first_party_for_cookies); 177 EXPECT_EQ(kUrl3, main_loader->request_info()->first_party_for_cookies);
123 EXPECT_TRUE(main_loader->request_info()->is_main_frame); 178 EXPECT_TRUE(main_loader->request_info()->is_main_frame);
124 EXPECT_FALSE(main_loader->request_info()->parent_is_main_frame); 179 EXPECT_FALSE(main_loader->request_info()->parent_is_main_frame);
180
181 // Main frame navigation to a different site should use a speculative
182 // RenderFrameHost.
183 EXPECT_TRUE(GetSpeculativeRenderFrameHost(root_node));
184
185 // The above situation regarding subframe navigations is valid here.
186 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
187 switches::kSitePerProcess)) {
188 EXPECT_TRUE(GetSpeculativeRenderFrameHost(subframe_node));
189 } else {
190 EXPECT_FALSE(GetSpeculativeRenderFrameHost(subframe_node));
191 }
125 } 192 }
126 193
127 // PlzNavigate: Test that RequestNavigation creates a NavigationRequest and that 194 // PlzNavigate: Test that RequestNavigation creates a NavigationRequest and that
128 // RenderFrameHost is not modified when the navigation commits. 195 // RenderFrameHost is not modified when the navigation commits.
129 TEST_F(NavigatorTestWithBrowserSideNavigation, NoLiveRenderer) { 196 TEST_F(NavigatorTestWithBrowserSideNavigation, NoLiveRenderer) {
130 const GURL kUrl("http://www.google.com/"); 197 const GURL kUrl("http://www.google.com/");
131 198
132 EXPECT_FALSE(main_test_rfh()->render_view_host()->IsRenderViewLive()); 199 EXPECT_FALSE(main_test_rfh()->render_view_host()->IsRenderViewLive());
133 FrameTreeNode* node = main_test_rfh()->frame_tree_node(); 200 RenderFrameHostImpl* rfh = main_test_rfh();
201 FrameTreeNode* node = rfh->frame_tree_node();
134 SendRequestNavigation(node, kUrl); 202 SendRequestNavigation(node, kUrl);
203
204 // A NavigationRequest should have been generated.
135 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node); 205 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node);
136 // A NavigationRequest should have been generated.
137 EXPECT_TRUE(main_request != NULL); 206 EXPECT_TRUE(main_request != NULL);
138 RenderFrameHostImpl* rfh = main_test_rfh(); 207
208 // As we're re-using the current RenderFrameHost, no speculative one should be
209 // created.
210 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
139 211
140 // Now return the response without any redirects. This will cause the 212 // Now return the response without any redirects. This will cause the
141 // navigation to commit at the same URL. 213 // navigation to commit at the same URL.
142 scoped_refptr<ResourceResponse> response(new ResourceResponse); 214 scoped_refptr<ResourceResponse> response(new ResourceResponse);
143 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted( 215 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted(
144 response, MakeEmptyStream()); 216 response, MakeEmptyStream());
145 main_request = GetNavigationRequestForFrameTreeNode(node); 217 main_request = GetNavigationRequestForFrameTreeNode(node);
146 218
147 // The main RFH should not have been changed, and the renderer should have 219 // The main RFH should not have been changed, and the renderer should have
148 // been initialized. 220 // been initialized.
149 EXPECT_EQ(rfh, main_test_rfh()); 221 EXPECT_EQ(rfh, main_test_rfh());
150 EXPECT_TRUE(main_test_rfh()->IsRenderFrameLive()); 222 EXPECT_TRUE(main_test_rfh()->IsRenderFrameLive());
151 EXPECT_TRUE(main_test_rfh()->render_view_host()->IsRenderViewLive()); 223 EXPECT_TRUE(main_test_rfh()->render_view_host()->IsRenderViewLive());
152 } 224 }
153 225
154 // PlzNavigate: Test that commiting an HTTP 204 or HTTP 205 response cancels the 226 // PlzNavigate: Test that committing an HTTP 204 or HTTP 205 response cancels
155 // navigation. 227 // the navigation.
156 TEST_F(NavigatorTestWithBrowserSideNavigation, NoContent) { 228 TEST_F(NavigatorTestWithBrowserSideNavigation, NoContent) {
157 const GURL kUrl1("http://www.chromium.org/"); 229 const GURL kUrl1("http://www.chromium.org/");
158 const GURL kUrl2("http://www.google.com/"); 230 const GURL kUrl2("http://www.google.com/");
159 231
160 // Load a URL. 232 // Load a URL.
161 contents()->NavigateAndCommit(kUrl1); 233 contents()->NavigateAndCommit(kUrl1);
162 RenderFrameHostImpl* rfh = main_test_rfh();
163 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, rfh->rfh_state());
164 FrameTreeNode* node = main_test_rfh()->frame_tree_node(); 234 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
165 235
166 // Navigate to a different site. 236 // Navigate to a different site.
237 process()->sink().ClearMessages();
167 SendRequestNavigation(node, kUrl2); 238 SendRequestNavigation(node, kUrl2);
168 main_test_rfh()->SendBeginNavigationWithURL(kUrl2); 239 main_test_rfh()->SendBeginNavigationWithURL(kUrl2);
240
169 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node); 241 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node);
170 ASSERT_TRUE(main_request); 242 ASSERT_TRUE(main_request);
171 243
244 // Navigations to a different site do create a speculative RenderFrameHost.
245 EXPECT_TRUE(GetSpeculativeRenderFrameHost(node));
246
172 // Commit an HTTP 204 response. 247 // Commit an HTTP 204 response.
173 scoped_refptr<ResourceResponse> response(new ResourceResponse); 248 scoped_refptr<ResourceResponse> response(new ResourceResponse);
174 const char kNoContentHeaders[] = "HTTP/1.1 204 No Content\0\0"; 249 const char kNoContentHeaders[] = "HTTP/1.1 204 No Content\0\0";
175 response->head.headers = new net::HttpResponseHeaders( 250 response->head.headers = new net::HttpResponseHeaders(
176 std::string(kNoContentHeaders, arraysize(kNoContentHeaders))); 251 std::string(kNoContentHeaders, arraysize(kNoContentHeaders)));
177 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted( 252 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted(
178 response, MakeEmptyStream()); 253 response, MakeEmptyStream());
179 254
180 // There should be no pending RenderFrameHost; the navigation was aborted. 255 // There should be no pending nor speculative RenderFrameHost; the navigation
256 // was aborted.
257 EXPECT_FALSE(DidRenderFrameHostCommit(main_test_rfh()));
181 EXPECT_FALSE(GetNavigationRequestForFrameTreeNode(node)); 258 EXPECT_FALSE(GetNavigationRequestForFrameTreeNode(node));
182 EXPECT_FALSE(node->render_manager()->pending_frame_host()); 259 EXPECT_FALSE(node->render_manager()->pending_frame_host());
260 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
183 261
184 // Now, repeat the test with 205 Reset Content. 262 // Now, repeat the test with 205 Reset Content.
185 263
186 // Navigate to a different site again. 264 // Navigate to a different site again.
265 process()->sink().ClearMessages();
187 SendRequestNavigation(node, kUrl2); 266 SendRequestNavigation(node, kUrl2);
188 main_test_rfh()->SendBeginNavigationWithURL(kUrl2); 267 main_test_rfh()->SendBeginNavigationWithURL(kUrl2);
268
189 main_request = GetNavigationRequestForFrameTreeNode(node); 269 main_request = GetNavigationRequestForFrameTreeNode(node);
190 ASSERT_TRUE(main_request); 270 ASSERT_TRUE(main_request);
271 EXPECT_TRUE(GetSpeculativeRenderFrameHost(node));
191 272
192 // Commit an HTTP 205 response. 273 // Commit an HTTP 205 response.
193 response = new ResourceResponse; 274 response = new ResourceResponse;
194 const char kResetContentHeaders[] = "HTTP/1.1 205 Reset Content\0\0"; 275 const char kResetContentHeaders[] = "HTTP/1.1 205 Reset Content\0\0";
195 response->head.headers = new net::HttpResponseHeaders( 276 response->head.headers = new net::HttpResponseHeaders(
196 std::string(kResetContentHeaders, arraysize(kResetContentHeaders))); 277 std::string(kResetContentHeaders, arraysize(kResetContentHeaders)));
197 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted( 278 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted(
198 response, MakeEmptyStream()); 279 response, MakeEmptyStream());
199 280
200 // There should be no pending RenderFrameHost; the navigation was aborted. 281 // There should be no pending nor speculative RenderFrameHost; the navigation
282 // was aborted.
283 EXPECT_FALSE(DidRenderFrameHostCommit(main_test_rfh()));
201 EXPECT_FALSE(GetNavigationRequestForFrameTreeNode(node)); 284 EXPECT_FALSE(GetNavigationRequestForFrameTreeNode(node));
202 EXPECT_FALSE(node->render_manager()->pending_frame_host()); 285 EXPECT_FALSE(node->render_manager()->pending_frame_host());
286 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
203 } 287 }
204 288
205 // PlzNavigate: Test that a new RenderFrameHost is created when doing a cross 289 // PlzNavigate: Test that a new RenderFrameHost is created when doing a cross
206 // site navigation. 290 // site navigation.
207 TEST_F(NavigatorTestWithBrowserSideNavigation, CrossSiteNavigation) { 291 TEST_F(NavigatorTestWithBrowserSideNavigation, CrossSiteNavigation) {
208 const GURL kUrl1("http://www.chromium.org/"); 292 const GURL kUrl1("http://www.chromium.org/");
209 const GURL kUrl2("http://www.google.com/"); 293 const GURL kUrl2("http://www.google.com/");
210 294
211 contents()->NavigateAndCommit(kUrl1); 295 contents()->NavigateAndCommit(kUrl1);
212 RenderFrameHostImpl* rfh = main_test_rfh(); 296 RenderFrameHostImpl* initial_rfh = main_test_rfh();
213 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, rfh->rfh_state());
214 FrameTreeNode* node = main_test_rfh()->frame_tree_node(); 297 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
215 298
216 // Navigate to a different site. 299 // Navigate to a different site.
300 process()->sink().ClearMessages();
217 SendRequestNavigation(node, kUrl2); 301 SendRequestNavigation(node, kUrl2);
218 main_test_rfh()->SendBeginNavigationWithURL(kUrl2); 302 main_test_rfh()->SendBeginNavigationWithURL(kUrl2);
219 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node); 303 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node);
220 ASSERT_TRUE(main_request); 304 ASSERT_TRUE(main_request);
305 EXPECT_TRUE(GetSpeculativeRenderFrameHost(node));
221 306
222 scoped_refptr<ResourceResponse> response(new ResourceResponse); 307 scoped_refptr<ResourceResponse> response(new ResourceResponse);
223 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted( 308 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted(
224 response, MakeEmptyStream()); 309 response, MakeEmptyStream());
225 RenderFrameHostImpl* pending_rfh = 310 TestRenderFrameHost* speculative_rfh = GetSpeculativeRenderFrameHost(node);
226 node->render_manager()->pending_frame_host(); 311 ASSERT_TRUE(speculative_rfh);
227 ASSERT_TRUE(pending_rfh); 312 EXPECT_TRUE(DidRenderFrameHostCommit(speculative_rfh));
228 EXPECT_NE(pending_rfh, rfh); 313 EXPECT_FALSE(DidRenderFrameHostCommit(main_test_rfh()));
229 EXPECT_TRUE(pending_rfh->IsRenderFrameLive()); 314
230 EXPECT_TRUE(pending_rfh->render_view_host()->IsRenderViewLive()); 315 speculative_rfh->SendNavigate(0, kUrl2);
316
317 RenderFrameHostImpl* final_rfh = main_test_rfh();
318 EXPECT_EQ(speculative_rfh, final_rfh);
319 EXPECT_NE(initial_rfh, final_rfh);
320 EXPECT_TRUE(final_rfh->IsRenderFrameLive());
321 EXPECT_TRUE(final_rfh->render_view_host()->IsRenderViewLive());
322 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
231 } 323 }
232 324
233 // PlzNavigate: Test that redirects are followed. 325 // PlzNavigate: Test that redirects are followed and the speculative renderer
326 // logic behaves as expected.
234 TEST_F(NavigatorTestWithBrowserSideNavigation, RedirectCrossSite) { 327 TEST_F(NavigatorTestWithBrowserSideNavigation, RedirectCrossSite) {
235 const GURL kUrl1("http://www.chromium.org/"); 328 const GURL kUrl1("http://www.chromium.org/");
236 const GURL kUrl2("http://www.google.com/"); 329 const GURL kUrl2("http://www.google.com/");
237 330
238 contents()->NavigateAndCommit(kUrl1); 331 contents()->NavigateAndCommit(kUrl1);
239 RenderFrameHostImpl* rfh = main_test_rfh(); 332 RenderFrameHostImpl* rfh = main_test_rfh();
240 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, rfh->rfh_state());
241 FrameTreeNode* node = main_test_rfh()->frame_tree_node(); 333 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
242 334
243 // Navigate to a URL on the same site. 335 // Navigate to a URL on the same site.
336 process()->sink().ClearMessages();
244 SendRequestNavigation(node, kUrl1); 337 SendRequestNavigation(node, kUrl1);
245 main_test_rfh()->SendBeginNavigationWithURL(kUrl1); 338 main_test_rfh()->SendBeginNavigationWithURL(kUrl1);
246 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node); 339 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node);
247 ASSERT_TRUE(main_request); 340 ASSERT_TRUE(main_request);
341 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
248 342
249 // It then redirects to another site. 343 // It then redirects to another site.
250 net::RedirectInfo redirect_info; 344 net::RedirectInfo redirect_info;
251 redirect_info.status_code = 302; 345 redirect_info.status_code = 302;
252 redirect_info.new_method = "GET"; 346 redirect_info.new_method = "GET";
253 redirect_info.new_url = kUrl2; 347 redirect_info.new_url = kUrl2;
254 redirect_info.new_first_party_for_cookies = kUrl2; 348 redirect_info.new_first_party_for_cookies = kUrl2;
255 scoped_refptr<ResourceResponse> response(new ResourceResponse); 349 scoped_refptr<ResourceResponse> response(new ResourceResponse);
256 GetLoaderForNavigationRequest(main_request)->CallOnRequestRedirected( 350 GetLoaderForNavigationRequest(main_request)->CallOnRequestRedirected(
257 redirect_info, response); 351 redirect_info, response);
258 352
259 // The redirect should have been followed. 353 // The redirect should have been followed.
260 EXPECT_EQ(1, GetLoaderForNavigationRequest(main_request)->redirect_count()); 354 EXPECT_EQ(1, GetLoaderForNavigationRequest(main_request)->redirect_count());
355 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
261 356
262 // Then it commits. 357 // Then it commits.
263 response = new ResourceResponse; 358 response = new ResourceResponse;
264 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted( 359 GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted(
265 response, MakeEmptyStream()); 360 response, MakeEmptyStream());
266 RenderFrameHostImpl* pending_rfh = 361 TestRenderFrameHost* final_speculative_rfh =
267 node->render_manager()->pending_frame_host(); 362 GetSpeculativeRenderFrameHost(node);
268 ASSERT_TRUE(pending_rfh); 363 EXPECT_TRUE(final_speculative_rfh);
269 EXPECT_NE(pending_rfh, rfh); 364 EXPECT_TRUE(DidRenderFrameHostCommit(final_speculative_rfh));
270 EXPECT_TRUE(pending_rfh->IsRenderFrameLive()); 365
271 EXPECT_TRUE(pending_rfh->render_view_host()->IsRenderViewLive()); 366 // And commits provisional load.
367 final_speculative_rfh->SendNavigate(0, kUrl2);
368 RenderFrameHostImpl* final_rfh = main_test_rfh();
369 ASSERT_TRUE(final_rfh);
370 EXPECT_NE(rfh, final_rfh);
371 EXPECT_EQ(final_speculative_rfh, final_rfh);
372 EXPECT_TRUE(final_rfh->IsRenderFrameLive());
373 EXPECT_TRUE(final_rfh->render_view_host()->IsRenderViewLive());
374 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
272 } 375 }
273 376
274 // PlzNavigate: Test that a navigation is cancelled if another request has been 377 // PlzNavigate: Test that a navigation is canceled if another request has been
275 // issued in the meantime. 378 // issued in the meantime. Also confirms that the speculative renderer is
379 // correctly updated in the process.
276 TEST_F(NavigatorTestWithBrowserSideNavigation, ReplacePendingNavigation) { 380 TEST_F(NavigatorTestWithBrowserSideNavigation, ReplacePendingNavigation) {
277 const GURL kUrl0("http://www.wikipedia.org/"); 381 const GURL kUrl0("http://www.wikipedia.org/");
278 const GURL kUrl0_site = SiteInstance::GetSiteForURL(browser_context(), kUrl0);
279 const GURL kUrl1("http://www.chromium.org/"); 382 const GURL kUrl1("http://www.chromium.org/");
383 const GURL kUrl1_site = SiteInstance::GetSiteForURL(browser_context(), kUrl1);
280 const GURL kUrl2("http://www.google.com/"); 384 const GURL kUrl2("http://www.google.com/");
281 const GURL kUrl2_site = SiteInstance::GetSiteForURL(browser_context(), kUrl2); 385 const GURL kUrl2_site = SiteInstance::GetSiteForURL(browser_context(), kUrl2);
282 386
283 // Initialization. 387 // Initialization.
284 contents()->NavigateAndCommit(kUrl0); 388 contents()->NavigateAndCommit(kUrl0);
285 FrameTreeNode* node = main_test_rfh()->frame_tree_node(); 389 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
286 EXPECT_EQ(kUrl0_site, main_test_rfh()->GetSiteInstance()->GetSiteURL());
287 390
288 // Request navigation to the 1st URL. 391 // Request navigation to the 1st URL.
392 process()->sink().ClearMessages();
289 SendRequestNavigation(node, kUrl1); 393 SendRequestNavigation(node, kUrl1);
290 main_test_rfh()->SendBeginNavigationWithURL(kUrl1); 394 main_test_rfh()->SendBeginNavigationWithURL(kUrl1);
291 NavigationRequest* request1 = GetNavigationRequestForFrameTreeNode(node); 395 NavigationRequest* request1 = GetNavigationRequestForFrameTreeNode(node);
292 ASSERT_TRUE(request1); 396 ASSERT_TRUE(request1);
293 EXPECT_EQ(kUrl1, request1->common_params().url); 397 EXPECT_EQ(kUrl1, request1->common_params().url);
294 base::WeakPtr<TestNavigationURLLoader> loader1 = 398 base::WeakPtr<TestNavigationURLLoader> loader1 =
295 GetLoaderForNavigationRequest(request1)->AsWeakPtr(); 399 GetLoaderForNavigationRequest(request1)->AsWeakPtr();
296 400
401 // Confirm a speculative RFH was created.
402 TestRenderFrameHost* speculative_rfh = GetSpeculativeRenderFrameHost(node);
403 ASSERT_TRUE(speculative_rfh);
404 int32 site_instance_id_1 = speculative_rfh->GetSiteInstance()->GetId();
405 EXPECT_EQ(kUrl1_site, speculative_rfh->GetSiteInstance()->GetSiteURL());
406
297 // Request navigation to the 2nd URL; the NavigationRequest must have been 407 // Request navigation to the 2nd URL; the NavigationRequest must have been
298 // replaced by a new one with a different URL. 408 // replaced by a new one with a different URL.
299 SendRequestNavigation(node, kUrl2); 409 SendRequestNavigation(node, kUrl2);
300 main_test_rfh()->SendBeginNavigationWithURL(kUrl2); 410 main_test_rfh()->SendBeginNavigationWithURL(kUrl2);
301 NavigationRequest* request2 = GetNavigationRequestForFrameTreeNode(node); 411 NavigationRequest* request2 = GetNavigationRequestForFrameTreeNode(node);
302 ASSERT_TRUE(request2); 412 ASSERT_TRUE(request2);
303 EXPECT_EQ(kUrl2, request2->common_params().url); 413 EXPECT_EQ(kUrl2, request2->common_params().url);
304 414
305 // Confirm that the first loader got destroyed. 415 // Confirm that the first loader got destroyed.
306 EXPECT_FALSE(loader1); 416 EXPECT_FALSE(loader1);
307 417
308 // Confirm that the commit corresponds to the new request. 418 // Confirm that a new speculative RFH was created.
419 speculative_rfh = GetSpeculativeRenderFrameHost(node);
420 ASSERT_TRUE(speculative_rfh);
421 int32 site_instance_id_2 = speculative_rfh->GetSiteInstance()->GetId();
422 EXPECT_NE(site_instance_id_1, site_instance_id_2);
423
424 // Commit.
309 scoped_refptr<ResourceResponse> response(new ResourceResponse); 425 scoped_refptr<ResourceResponse> response(new ResourceResponse);
310 GetLoaderForNavigationRequest(request2)->CallOnResponseStarted( 426 GetLoaderForNavigationRequest(request2)->CallOnResponseStarted(
311 response, MakeEmptyStream()); 427 response, MakeEmptyStream());
312 RenderFrameHostImpl* pending_rfh = 428 EXPECT_TRUE(DidRenderFrameHostCommit(speculative_rfh));
313 node->render_manager()->pending_frame_host(); 429 EXPECT_FALSE(DidRenderFrameHostCommit(main_test_rfh()));
314 ASSERT_TRUE(pending_rfh); 430
315 EXPECT_EQ(kUrl2_site, pending_rfh->GetSiteInstance()->GetSiteURL()); 431 // And commit provisional load.
432 speculative_rfh->SendNavigate(0, kUrl2);
433
434 // Confirm that the commit corresponds to the new request.
435 ASSERT_TRUE(main_test_rfh());
436 EXPECT_EQ(kUrl2_site, main_test_rfh()->GetSiteInstance()->GetSiteURL());
437
438 // Confirm that the committed RFH is the new speculative one.
439 EXPECT_EQ(site_instance_id_2, main_test_rfh()->GetSiteInstance()->GetId());
316 } 440 }
317 441
318 // PlzNavigate: Test that a reload navigation is properly signaled to the 442 // PlzNavigate: Test that a reload navigation is properly signaled to the
319 // renderer when the navigation can commit. 443 // renderer when the navigation can commit. Speculative renderers should not be
444 // created at any step.
320 TEST_F(NavigatorTestWithBrowserSideNavigation, Reload) { 445 TEST_F(NavigatorTestWithBrowserSideNavigation, Reload) {
321 const GURL kUrl("http://www.google.com/"); 446 const GURL kUrl("http://www.google.com/");
322 contents()->NavigateAndCommit(kUrl); 447 contents()->NavigateAndCommit(kUrl);
323 448
324 FrameTreeNode* node = main_test_rfh()->frame_tree_node(); 449 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
325 SendRequestNavigationWithParameters( 450 SendRequestNavigationWithParameters(
326 node, kUrl, Referrer(), ui::PAGE_TRANSITION_LINK, 451 node, kUrl, Referrer(), ui::PAGE_TRANSITION_LINK,
327 NavigationController::RELOAD); 452 NavigationController::RELOAD);
328 contents()->GetMainFrame()->SendBeginNavigationWithURL(kUrl); 453 main_test_rfh()->SendBeginNavigationWithURL(kUrl);
329 // A NavigationRequest should have been generated. 454 // A NavigationRequest should have been generated.
330 NavigationRequest* main_request = 455 NavigationRequest* main_request =
331 GetNavigationRequestForFrameTreeNode(node); 456 GetNavigationRequestForFrameTreeNode(node);
332 ASSERT_TRUE(main_request != NULL); 457 ASSERT_TRUE(main_request != NULL);
333 EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD, 458 EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD,
334 main_request->common_params().navigation_type); 459 main_request->common_params().navigation_type);
335 int page_id = contents()->GetMaxPageIDForSiteInstance( 460 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
336 main_test_rfh()->GetSiteInstance()) + 1; 461
337 main_test_rfh()->SendNavigate(page_id, kUrl); 462 main_test_rfh()->SendNavigate(0, kUrl);
463 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
338 464
339 // Now do a shift+reload. 465 // Now do a shift+reload.
340 SendRequestNavigationWithParameters( 466 SendRequestNavigationWithParameters(
341 node, kUrl, Referrer(), ui::PAGE_TRANSITION_LINK, 467 node, kUrl, Referrer(), ui::PAGE_TRANSITION_LINK,
342 NavigationController::RELOAD_IGNORING_CACHE); 468 NavigationController::RELOAD_IGNORING_CACHE);
343 contents()->GetMainFrame()->SendBeginNavigationWithURL(kUrl); 469 main_test_rfh()->SendBeginNavigationWithURL(kUrl);
344 // A NavigationRequest should have been generated. 470 // A NavigationRequest should have been generated.
345 main_request = GetNavigationRequestForFrameTreeNode(node); 471 main_request = GetNavigationRequestForFrameTreeNode(node);
346 ASSERT_TRUE(main_request != NULL); 472 ASSERT_TRUE(main_request != NULL);
347 EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD_IGNORING_CACHE, 473 EXPECT_EQ(FrameMsg_Navigate_Type::RELOAD_IGNORING_CACHE,
348 main_request->common_params().navigation_type); 474 main_request->common_params().navigation_type);
475 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
476 }
477
478 // PlzNavigate: Confirm that a speculative RenderFrameHost is used when
479 // navigating from one site to the another.
480 TEST_F(NavigatorTestWithBrowserSideNavigation,
481 SpeculativeRendererWorksBaseCase) {
482 // Navigate to an initial site.
483 const GURL kUrlInit("http://wikipedia.org/");
484 contents()->NavigateAndCommit(kUrlInit);
485 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
486
487 // Begin navigating to another site.
488 const GURL kUrl("http://google.com/");
489 process()->sink().ClearMessages();
490 SendRequestNavigation(node, kUrl);
491 main_test_rfh()->SendBeginNavigationWithURL(kUrl);
492 TestRenderFrameHost* speculative_rfh = GetSpeculativeRenderFrameHost(node);
493 ASSERT_TRUE(speculative_rfh);
494 EXPECT_NE(speculative_rfh, main_test_rfh());
495 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl),
496 speculative_rfh->GetSiteInstance()->GetSiteURL());
497 EXPECT_FALSE(node->render_manager()->pending_frame_host());
498 int32 site_instance_id = speculative_rfh->GetSiteInstance()->GetId();
499
500 // Ask Navigator to commit the navigation by simulating a call to
501 // OnResponseStarted.
502 scoped_refptr<ResourceResponse> response(new ResourceResponse);
503 GetLoaderForNavigationRequest(GetNavigationRequestForFrameTreeNode(node))
504 ->CallOnResponseStarted(response, MakeEmptyStream());
505 speculative_rfh = GetSpeculativeRenderFrameHost(node);
506 ASSERT_TRUE(speculative_rfh);
507 EXPECT_TRUE(DidRenderFrameHostCommit(speculative_rfh));
508 EXPECT_EQ(site_instance_id, speculative_rfh->GetSiteInstance()->GetId());
509 EXPECT_FALSE(node->render_manager()->pending_frame_host());
510
511 // Invoke OnDidCommitProvisionalLoad.
512 speculative_rfh->SendNavigate(0, kUrl);
513 EXPECT_EQ(site_instance_id, main_test_rfh()->GetSiteInstance()->GetId());
514 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
515 EXPECT_FALSE(node->render_manager()->pending_frame_host());
516 }
517
518 // PlzNavigate: Confirm that a speculative RenderFrameHost is thrown away when
519 // the final URL's site differs from the initial one due to redirects.
520 TEST_F(NavigatorTestWithBrowserSideNavigation,
521 SpeculativeRendererDiscardedAfterRedirectToAnotherSite) {
522 // Navigate to an initial site.
523 const GURL kUrlInit("http://wikipedia.org/");
524 contents()->NavigateAndCommit(kUrlInit);
525 FrameTreeNode* node = main_test_rfh()->frame_tree_node();
526 int32 init_site_instance_id = main_test_rfh()->GetSiteInstance()->GetId();
527
528 // Begin navigating to another site.
529 const GURL kUrl("http://google.com/");
530 process()->sink().ClearMessages();
531 SendRequestNavigation(node, kUrl);
532 main_test_rfh()->SendBeginNavigationWithURL(kUrl);
533 TestRenderFrameHost* speculative_rfh = GetSpeculativeRenderFrameHost(node);
534 int32 site_instance_id = speculative_rfh->GetSiteInstance()->GetId();
535 EXPECT_EQ(init_site_instance_id, main_test_rfh()->GetSiteInstance()->GetId());
536 ASSERT_TRUE(speculative_rfh);
537 EXPECT_NE(speculative_rfh, main_test_rfh());
538 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl),
539 speculative_rfh->GetSiteInstance()->GetSiteURL());
540
541 // It then redirects to yet another site.
542 NavigationRequest* main_request = GetNavigationRequestForFrameTreeNode(node);
543 ASSERT_TRUE(main_request);
544 const GURL kUrlRedirect("https://www.google.com/");
545 net::RedirectInfo redirect_info;
546 redirect_info.status_code = 302;
547 redirect_info.new_method = "GET";
548 redirect_info.new_url = kUrlRedirect;
549 redirect_info.new_first_party_for_cookies = kUrlRedirect;
550 scoped_refptr<ResourceResponse> response(new ResourceResponse);
551 GetLoaderForNavigationRequest(main_request)
552 ->CallOnRequestRedirected(redirect_info, response);
553 EXPECT_EQ(init_site_instance_id, main_test_rfh()->GetSiteInstance()->GetId());
554 speculative_rfh = GetSpeculativeRenderFrameHost(node);
555 ASSERT_TRUE(speculative_rfh);
556
557 // TODO(carlosk): once the speculative RenderFrameHost updates with redirects
558 // this next check will be changed to verify that it actually happens.
559 EXPECT_EQ(site_instance_id, speculative_rfh->GetSiteInstance()->GetId());
560
561 // Commit the navigation with Navigator by simulating the call to
562 // OnResponseStarted.
563 response = new ResourceResponse;
564 GetLoaderForNavigationRequest(main_request)
565 ->CallOnResponseStarted(response, MakeEmptyStream());
566 speculative_rfh = GetSpeculativeRenderFrameHost(node);
567 EXPECT_TRUE(DidRenderFrameHostCommit(speculative_rfh));
568 EXPECT_EQ(init_site_instance_id, main_test_rfh()->GetSiteInstance()->GetId());
569
570 // Once commit happens the speculative RenderFrameHost is already updated to
571 // match the known final SiteInstance.
572 ASSERT_TRUE(speculative_rfh);
573 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrlRedirect),
574 speculative_rfh->GetSiteInstance()->GetSiteURL());
575 int32 redirect_site_instance_id = speculative_rfh->GetSiteInstance()->GetId();
576
577 // Invoke OnDidCommitProvisionalLoad.
578 speculative_rfh->SendNavigate(0, kUrlRedirect);
579
580 // Check that the speculative RenderFrameHost was swapped in.
581 EXPECT_EQ(redirect_site_instance_id,
582 main_test_rfh()->GetSiteInstance()->GetId());
583 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
584 }
585
586 // PlzNavigate: Verify that a previously swapped out RenderFrameHost is
587 // correctly reused when spawning a speculative RenderFrameHost in a navigation
588 // using the same SiteInstance.
589 TEST_F(NavigatorTestWithBrowserSideNavigation,
590 SpeculativeRendererReuseSwappedOutRFH) {
591 // Navigate to an initial site.
592 const GURL kUrl1("http://wikipedia.org/");
593 contents()->NavigateAndCommit(kUrl1);
594 TestRenderFrameHost* rfh1 = main_test_rfh();
595 FrameTreeNode* node = rfh1->frame_tree_node();
596 RenderFrameHostManager* rfhm = node->render_manager();
597
598 // Increment active frame count to cause the RenderFrameHost to be swapped out
599 // (instead of immediately destroyed).
600 rfh1->GetSiteInstance()->increment_active_frame_count();
601
602 // Navigate to another site to swap out the initial RenderFrameHost.
603 const GURL kUrl2("http://chromium.org/");
604 contents()->NavigateAndCommit(kUrl2);
605 ASSERT_NE(rfh1, main_test_rfh());
606 EXPECT_NE(RenderFrameHostImpl::STATE_DEFAULT, rfh1->rfh_state());
607 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, main_test_rfh()->rfh_state());
608 EXPECT_TRUE(rfhm->IsOnSwappedOutList(rfh1));
609
610 // Now go back to the initial site so that the swapped out RenderFrameHost
611 // should be reused.
612 process()->sink().ClearMessages();
613 static_cast<MockRenderProcessHost*>(rfh1->GetProcess())
614 ->sink()
615 .ClearMessages();
616 SendRequestNavigation(node, kUrl1);
617 main_test_rfh()->SendBeginNavigationWithURL(kUrl1);
618 EXPECT_EQ(rfh1, GetSpeculativeRenderFrameHost(node));
619 EXPECT_NE(RenderFrameHostImpl::STATE_DEFAULT,
620 GetSpeculativeRenderFrameHost(node)->rfh_state());
621
622 scoped_refptr<ResourceResponse> response(new ResourceResponse);
623 GetLoaderForNavigationRequest(GetNavigationRequestForFrameTreeNode(node))
624 ->CallOnResponseStarted(response, MakeEmptyStream());
625 EXPECT_EQ(rfh1, GetSpeculativeRenderFrameHost(node));
626 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT,
627 GetSpeculativeRenderFrameHost(node)->rfh_state());
628 EXPECT_TRUE(DidRenderFrameHostCommit(rfh1));
629 EXPECT_FALSE(DidRenderFrameHostCommit(main_test_rfh()));
630
631 rfh1->SendNavigate(1, kUrl1);
632 EXPECT_EQ(rfh1, main_test_rfh());
633 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, rfh1->rfh_state());
634 EXPECT_FALSE(rfhm->IsOnSwappedOutList(rfh1));
349 } 635 }
350 636
351 } // namespace content 637 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698