PlzNavigate: Speculatively spawns a renderer process for navigations.

content/test/test_web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_TEST_WEB_CONTENTS_H_
 #define CONTENT_TEST_TEST_WEB_CONTENTS_H_
 
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/common/web_preferences.h"
 #include "content/public/test/web_contents_tester.h"
@@ skipping 99 matching lines @@
                        int route_id,
                        blink::WebPopupType popup_type) override;
   void CreateNewFullscreenWidget(int render_process_id, int route_id) override;
   void ShowCreatedWindow(int route_id,
                          WindowOpenDisposition disposition,
                          const gfx::Rect& initial_pos,
                          bool user_gesture) override;
   void ShowCreatedWidget(int route_id, const gfx::Rect& initial_pos) override;
   void ShowCreatedFullscreenWidget(int route_id) override;
 
+  // PlzNavigate
+  // Gets the speculative RenderFrameHost, if any, for the main frame.
+  TestRenderFrameHost* GetSpeculativeMainFrame() const;

[clamy, 2014/12/29 17:36:22]

This method is currently private and used exactly one time in
test_web_contents.cc and one line long. Please remove it if it is not going to
be used publicly or make it public if it will be used.

[carlosk, 2014/12/30 15:54:50]

Done.

+
+  // PlzNavigate
+  // Gets the whether the pending or the speculative RenderFrameHost, whichever
+  // makes sense for the current environment. Returns nullptr if the selected
+  // RenderFrameHost is not set.
+  TestRenderFrameHost* GetFutureMainFrame() const;

[clamy, 2014/12/29 17:36:22]

This method should not be private as we expect to use it in several unit tests.
Also please rephrase the comment with a description of what the method does in
the current code path, and then on a new line PlzNavigate: with a description of
what it does in PlzNavigate case.

[carlosk, 2014/12/30 15:54:50]

Done.

+
   RenderViewHostDelegateView* delegate_view_override_;
 
   // Expectations for arguments of |SetHistoryOffsetAndLength()|.
   bool expect_set_history_offset_and_length_;
   int expect_set_history_offset_and_length_history_offset_;
   int expect_set_history_offset_and_length_history_length_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_TEST_TEST_WEB_CONTENTS_H_