Issue 701953004: Reapply win gn fixes from

Issue 701953004: Reapply win gn fixes from (Closed)

Created:
6 years, 1 month ago by jam

Modified:
6 years, 1 month ago

Reviewers:
jamesr, scottmg

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+324 lines, -40 lines)			Patch
M	base/win/win_util.h	View	1 chunk	+1 line, -21 lines	0 comments	Download
M	base/win/win_util.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/toolchain/win/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/vs_toolchain.py	View	2 chunks	+0 lines, -11 lines	0 comments	Download
A	build/win/win_tool.py	View	1 chunk	+315 lines, -0 lines	0 comments	Download
M	net/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

jam

So to avoid this happening again, should we land these changes upstream in a way ...

6 years, 1 month ago (2014-11-05 02:45:53 UTC) #3

scottmg

I didn't realize mojo was pulling things from Chromium, otherwise I would have done these ...

6 years, 1 month ago (2014-11-05 02:52:52 UTC) #4

jam

Committed patchset #1 (id:20001) manually as 16917a007d20aaa02aecfd74760a685594229f76.

6 years, 1 month ago (2014-11-05 04:19:18 UTC) #6

jamesr

6 years, 1 month ago (2014-11-05 05:08:15 UTC) #7

Message was sent while issue was closed.

No, you have to land this patch in chromium.  We aren't carrying a fork of base/
in mojo.