Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 701933004: Change mojo url to always use mojo:foo instead of mojo://foo (Closed)

Created:
6 years, 1 month ago by qsr
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Change mojo url to always use mojo:foo instead of mojo://foo R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/de93437e5974558a19a12e4763d2a14a5ef27e0f

Patch Set 1 #

Patch Set 2 : Remove calls to AddStandardScheme #

Total comments: 4

Patch Set 3 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M examples/window_manager/debug_panel.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/main.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/context.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/switches.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/HACKING.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/README.md View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/network.sky View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/skydb View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M sky/tools/test_perf View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M sky/viewer/document_view.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
qsr
6 years, 1 month ago (2014-11-05 16:54:13 UTC) #2
Aaron Boodman
Calls to AddStandardScheme need to be changed too. Otherwise, GURL will convert foo:bar to foo://bar. ...
6 years, 1 month ago (2014-11-05 17:07:21 UTC) #3
qsr
On 2014/11/05 17:07:21, Aaron Boodman wrote: > Calls to AddStandardScheme need to be changed too. ...
6 years, 1 month ago (2014-11-05 18:13:18 UTC) #4
abarth-chromium
https://codereview.chromium.org/701933004/diff/20001/examples/window_manager/debug_panel.cc File examples/window_manager/debug_panel.cc (right): https://codereview.chromium.org/701933004/diff/20001/examples/window_manager/debug_panel.cc#newcode123 examples/window_manager/debug_panel.cc:123: Navigate("mojo:embedded_app/"); Why the trailing / ? https://codereview.chromium.org/701933004/diff/20001/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky ...
6 years, 1 month ago (2014-11-05 18:15:01 UTC) #5
qsr
https://codereview.chromium.org/701933004/diff/20001/examples/window_manager/debug_panel.cc File examples/window_manager/debug_panel.cc (right): https://codereview.chromium.org/701933004/diff/20001/examples/window_manager/debug_panel.cc#newcode123 examples/window_manager/debug_panel.cc:123: Navigate("mojo:embedded_app/"); On 2014/11/05 18:15:01, abarth wrote: > Why the ...
6 years, 1 month ago (2014-11-05 18:22:21 UTC) #6
qsr
gentle ping?
6 years, 1 month ago (2014-11-06 15:38:29 UTC) #7
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-06 16:10:24 UTC) #8
qsr
6 years, 1 month ago (2014-11-06 16:23:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
de93437e5974558a19a12e4763d2a14a5ef27e0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698