Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 701933003: Fix fast-variants feature in test driver. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix fast-variants feature in test driver. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M tools/run-tests.py View 2 chunks +1 line, -7 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL. This runs 2*9 tests now on tools/run-tests.py --arch ia32 --mode release mjsunit/asm/embenchen --time --report ...
6 years, 1 month ago (2014-11-05 12:54:16 UTC) #2
Benedikt Meurer
lgtm
6 years, 1 month ago (2014-11-05 12:54:52 UTC) #3
Michael Achenbach
Committed patchset #1 (id:1) manually as 25150 (presubmit successful).
6 years, 1 month ago (2014-11-05 13:05:40 UTC) #4
Jakob Kummerow
6 years, 1 month ago (2014-11-05 13:07:52 UTC) #5
Message was sent while issue was closed.
LGTM. Not too happy with the ever-increasing complexity, but I don't have a
better idea.

To fix --report, you'll have to adapt PrintReport in local/verbose.py, similar
to the existing line:

if list(o) == [statusfile.PASS]: passes += 1

Suggestion: Introduce a new predicate in statusfile.py: 

def IsPass(outcomes):
  return ((PASS in outcomes) and (not FAIL in outcomes) and
          (not CRASH in outcomes))

Then use that to replace the above line with:

if statusfile.IsPass(o): passes += 1

Powered by Google App Engine
This is Rietveld 408576698