Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: gclient.py

Issue 701893002: Don't enforce allowed_hosts for custom_deps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 86d45131786521073529607216f830503918ea38..f6db225c11c0d94e834580728faf3fad74011ed1 100755
--- a/gclient.py
+++ b/gclient.py
@@ -782,6 +782,9 @@ class Dependency(gclient_utils.WorkItem, DependencySettings):
return []
bad_deps = []
for dep in self._dependencies:
+ # Don't enforce this for custom_deps.
+ if dep.name in self._custom_deps:
+ continue
if isinstance(dep.url, basestring):
parsed_url = urlparse.urlparse(dep.url)
if parsed_url.netloc and parsed_url.netloc not in self._allowed_hosts:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698