Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 701873005: Handle failed GpuMemoryBuffer allocations properly. (Closed)

Created:
6 years, 1 month ago by alexst (slow to review)
Modified:
6 years, 1 month ago
Reviewers:
reveman, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Handle failed GpuMemoryBuffer allocations properly. It is possible for an allocation to fail on the gpu side, we should handle it gracefully. Currently we DCHECK that it succeeded in the browser, which in release leads to unexpected behaviour and NOTREACHED hit during destruction on the gpu side. BUG= Committed: https://crrev.com/34667610c029b3ca2faaf188e8f34cc1a726a1b6 Cr-Commit-Position: refs/heads/master@{#302721}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alexst (slow to review)
6 years, 1 month ago (2014-11-04 21:40:18 UTC) #3
piman
lgtm
6 years, 1 month ago (2014-11-04 21:43:38 UTC) #4
reveman
lgtm
6 years, 1 month ago (2014-11-04 22:31:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701873005/20001
6 years, 1 month ago (2014-11-04 23:29:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-11-05 00:35:30 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 00:36:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34667610c029b3ca2faaf188e8f34cc1a726a1b6
Cr-Commit-Position: refs/heads/master@{#302721}

Powered by Google App Engine
This is Rietveld 408576698