Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 701853002: [turbofan] Fix deopt for assignments in non-effect context. (Closed)

Created:
6 years, 1 month ago by Jarin
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deopt for assignments in non-effect context. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 6 chunks +11 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-assignment-in-test-context.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please?
6 years, 1 month ago (2014-11-04 15:24:11 UTC) #2
Michael Starzinger
LGTM.
6 years, 1 month ago (2014-11-04 16:03:37 UTC) #3
Jarin
6 years, 1 month ago (2014-11-05 13:08:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698