Fixes a couple problems with GC of unoptimized code.

runtime/vm/object.h

Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h	(revision 30197)
+++ runtime/vm/object.h	(working copy)
@@ -1503,13 +1503,6 @@
   // Sets function's code and code's function.
   void SetCode(const Code& value) const;
 
-  // Detaches code from the function by setting the code to null, and patches
-  // the code to be non-entrant.
-  void DetachCode() const;
-
-  // Reattaches code to the function, and patches the code to be entrant.
-  void ReattachCode(const Code& code) const;
-
   // Disables optimized code and switches to unoptimized code.
   void SwitchToUnoptimizedCode() const;
 
@@ -1997,6 +1990,7 @@
 
   FINAL_HEAP_OBJECT_IMPLEMENTATION(Function, Object);
   friend class Class;
+  friend class RawFunction;

[Ivan Posva, 2013/11/19 19:24:48]

What is this needed for?

[zra, 2013/11/22 17:18:54]

RawFunction::VisitFunctionPointers needs to access the private constructor of
Function. Added a comment.

 };
 
 
@@ -3354,6 +3348,10 @@
 
   FINAL_HEAP_OBJECT_IMPLEMENTATION(Code, Object);
   friend class Class;
+
+  // So that the RawFunction pointer visitor can determine whether code the
+  // function points to is optimized.
+  friend class RawFunction;
 };
 
 
@@ -4979,6 +4977,8 @@
   friend class TwoByteString;
   friend class ExternalOneByteString;
   friend class ExternalTwoByteString;
+  // So that the MarkingVisitor can print a debug string from a NoHandleScope.
+  friend class MarkingVisitor;
 };